fix: add result attribute when emitting telemetry event (#1088)

* fix: add result attribute when emitting telemetry event

* fix: remove comment

* fix: unit test

* fix: fix unit test

* fix: fix unit test

* feat(chat-client): open use input prompt for agentic chat and new prompt should st… (#1081)

feat: open use input prompt for agentic chat and new prompt should stop current response

* fix: ux polish for list directory tool messages. (#1075)

## Problem
- Existing UX shows multiple context list chatItem cards for list directory tool messages.
## Solution
- Use a `messageIdToUpdateListDir` state to store the messageId and update this for next list directory tool messages.
![image](https://github.com/user-attachments/assets/08fff204-0bbc-4467-b05b-7f90be062fc1)

## TODO:
- Need to combine both read and list directory tool messages into one context list.
- This code change is equivalent to this PR: aws/aws-toolkit-vscode#7006 in `feature/agentic-chat` branch.

* fix: execute command should show when no approval required & add more loading (#1091)

* fix: fix unit test

---------

Co-authored-by: invictus <[email protected]>
Co-authored-by: Laxman Reddy <[email protected]>
Co-authored-by: Zoe Lin <[email protected]>

Author: 4 people

server/aws-lsp-codewhisperer/src/language-server/chat/telemetry/chatTelemetryController.test.ts

@@ -54,7 +54,7 @@ describe('TelemetryController', () => {
 
         sinon.assert.calledOnceWithExactly(testFeatures.telemetry.emitMetric, {
             name: ChatTelemetryEventName.EnterFocusChat,
-            data: { credentialStartUrl: undefined },
+            data: { credentialStartUrl: undefined, result: 'Succeeded' },
         })
     })
 
@@ -67,7 +67,7 @@ describe('TelemetryController', () => {
 
         sinon.assert.calledOnceWithExactly(testFeatures.telemetry.emitMetric, {
             name: ChatTelemetryEventName.ExitFocusChat,
-            data: { credentialStartUrl: undefined },
+            data: { credentialStartUrl: undefined, result: 'Succeeded' },
         })
     })
 
@@ -104,6 +104,7 @@ describe('TelemetryController', () => {
             data: {
                 [CONVERSATION_ID_METRIC_KEY]: mockConversationId,
                 credentialStartUrl: undefined,
+                result: 'Succeeded',
             },
         })
     })

server/aws-lsp-codewhisperer/src/language-server/chat/telemetry/chatTelemetryController.ts

@@ -140,6 +140,7 @@ export class ChatTelemetryController {
             data: {
                 ...metric.data,
                 credentialStartUrl: this.#credentialsProvider.getConnectionMetadata()?.sso?.startUrl,
+                result: 'Succeeded',
             },
         })
     }
@@ -161,6 +162,7 @@ export class ChatTelemetryController {
                     ...metric.data,
                     credentialStartUrl: this.#credentialsProvider.getConnectionMetadata()?.sso?.startUrl,
                     [CONVERSATION_ID_METRIC_KEY]: conversationId,
+                    result: 'Succeeded',
                 },
             })
         }

server/aws-lsp-codewhisperer/src/shared/telemetry/telemetryService.test.ts

@@ -446,6 +446,7 @@ describe('TelemetryService', () => {
                     cwsprChatAcceptedCharactersLength: 100,
                     cwsprChatConversationId: 'conv123',
                     credentialStartUrl: 'idc-start-url',
+                    result: 'Succeeded',
                 },
             })
         })
@@ -752,6 +753,7 @@ describe('TelemetryService', () => {
                 cwsprChatModificationPercentage: 0.2,
                 codewhispererCustomizationArn: 'test-arn',
                 credentialStartUrl: 'idc-start-url',
+                result: 'Succeeded',
             },
         })
     })
@@ -874,6 +876,7 @@ describe('TelemetryService', () => {
                     cwsprChatActiveEditorTotalCharacters: 250,
                     cwsprChatActiveEditorImportCount: undefined,
                     codewhispererCustomizationArn: 'cust-123',
+                    result: 'Succeeded',
                 },
             })
         })

server/aws-lsp-codewhisperer/src/shared/telemetry/telemetryService.ts

@@ -254,6 +254,7 @@ export class TelemetryService {
                     ...metric,
                     [CONVERSATION_ID_METRIC_KEY]: options.conversationId,
                     credentialStartUrl: this.credentialsProvider.getConnectionMetadata()?.sso?.startUrl,
+                    result: 'Succeeded',
                 },
             })
         }
@@ -290,6 +291,7 @@ export class TelemetryService {
                     cwsprChatModificationPercentage: params.modificationPercentage,
                     codewhispererCustomizationArn: params.customizationArn,
                     credentialStartUrl: this.credentialsProvider.getConnectionMetadata()?.sso?.startUrl,
+                    result: 'Succeeded',
                 },
             })
         }
@@ -420,6 +422,7 @@ export class TelemetryService {
                     cwsprChatActiveEditorTotalCharacters: params.activeEditorTotalCharacters,
                     cwsprChatActiveEditorImportCount: additionalParams.chatActiveEditorImportCount,
                     codewhispererCustomizationArn: params.customizationArn,
+                    result: 'Succeeded',
                 },
             })
         }