refactor: removing some redundant code (#2364)

Author: laileni-aws

server/aws-lsp-codewhisperer/src/language-server/agenticChat/agenticChatController.ts

@@ -1331,7 +1331,7 @@ export class AgenticChatController implements ChatHandlers {
         if (result.data?.chatResult.body !== undefined) {
             this.#chatHistoryDb.replaceWithSummary(tabId, 'cwc', conversationIdentifier ?? '', {
                 body: result.data?.chatResult.body,
-                type: 'prompt' as any,
+                type: 'prompt' as ChatMessage['type'],
                 shouldDisplayMessage: true,
                 timestamp: new Date(),
             })
@@ -1451,7 +1451,7 @@ export class AgenticChatController implements ChatHandlers {
                 } else {
                     this.#chatHistoryDb.addMessage(tabId, 'cwc', conversationIdentifier, {
                         body: currentMessage.userInputMessage?.content ?? '',
-                        type: 'prompt' as any,
+                        type: 'prompt' as ChatMessage['type'],
                         userIntent: currentMessage.userInputMessage?.userIntent,
                         origin: currentMessage.userInputMessage?.origin,
                         userInputMessageContext: currentMessage.userInputMessage?.userInputMessageContext,
@@ -1527,7 +1527,7 @@ export class AgenticChatController implements ChatHandlers {
                 } else {
                     this.#chatHistoryDb.addMessage(tabId, 'cwc', conversationIdentifier ?? '', {
                         body: result.data?.chatResult.body,
-                        type: 'answer' as any,
+                        type: 'answer' as ChatMessage['type'],
                         codeReference: result.data.chatResult.codeReference,
                         relatedContent:
                             result.data.chatResult.relatedContent?.content &&

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/chatDb/chatDb.test.ts

@@ -91,30 +91,6 @@ describe('ChatDatabase', () => {
         })
     })
 
-    describe('replaceHistory', () => {
-        it('should replace history with messages', async () => {
-            await chatDb.databaseInitialize(0)
-            const tabId = 'tab-1'
-            const tabType = 'cwc'
-            const conversationId = 'conv-1'
-            const messages = [
-                { body: 'Test', type: 'prompt' as any, timestamp: new Date() },
-                { body: 'Thinking...', type: 'answer', timestamp: new Date() },
-            ]
-
-            // Call the method
-            chatDb.replaceHistory(tabId, tabType, conversationId, messages)
-
-            // Verify the messages array contains the summary and a dummy response
-            const messagesFromDb = chatDb.getMessages(tabId, 250)
-            assert.strictEqual(messagesFromDb.length, 2)
-            assert.strictEqual(messagesFromDb[0].body, 'Test')
-            assert.strictEqual(messagesFromDb[0].type, 'prompt')
-            assert.strictEqual(messagesFromDb[1].body, 'Thinking...')
-            assert.strictEqual(messagesFromDb[1].type, 'answer')
-        })
-    })
-
     describe('ensureValidMessageSequence', () => {
         it('should preserve valid alternating sequence', () => {
             const messages: Message[] = [

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/chatDb/chatDb.ts

@@ -636,50 +636,6 @@ export class ChatDatabase {
         }
     }
 
-    /**
-     * Replace history with summary/dummyResponse pair within a specified tab.
-     *
-     * This method manages chat messages by creating a new history with compacted summary and dummy response pairs
-     */
-    replaceHistory(tabId: string, tabType: TabType, conversationId: string, messages: Message[]) {
-        if (this.isInitialized()) {
-            const clientType = this.#features.lsp.getClientInitializeParams()?.clientInfo?.name || 'unknown'
-            const tabCollection = this.#db.getCollection<Tab>(TabCollection)
-
-            this.#features.logging.log(
-                `Update history with new messages: tabId=${tabId}, tabType=${tabType}, conversationId=${conversationId}`
-            )
-
-            const oldHistoryId = this.getOrCreateHistoryId(tabId)
-            // create a new historyId to start fresh
-            const historyId = this.createHistoryId(tabId)
-
-            const tabData = historyId ? tabCollection.findOne({ historyId }) : undefined
-            const tabTitle = tabData?.title || 'Amazon Q Chat'
-            messages = messages.map(msg => this.formatChatHistoryMessage(msg))
-            this.#features.logging.log(`Overriding tab with new historyId=${historyId}`)
-            tabCollection.insert({
-                historyId,
-                updatedAt: new Date(),
-                isOpen: true,
-                tabType: tabType,
-                title: tabTitle,
-                conversations: [
-                    {
-                        conversationId,
-                        clientType,
-                        updatedAt: new Date(),
-                        messages: messages,
-                    },
-                ],
-            })
-
-            if (oldHistoryId) {
-                tabCollection.findAndRemove({ historyId: oldHistoryId })
-            }
-        }
-    }
-
     formatChatHistoryMessage(message: Message): Message {
         if (message.type === ('prompt' as ChatItemType)) {
             let hasToolResults = false