Skip to content

Commit e11c544

Browse files
akoremanAlice Koreman
andauthored
fix: set resolveProvider to false in init handler json and yaml language servers (#2391)
Problem Currently, both the JSON and YAML generic language servers respond with resolveProvider: true in their initialization response. This signals to clients that these language servers support completion item resolve requests, which these servers don't actually support, resulting in errors when clients send resolve requests. Solution This updates resolveProvider to false to accurately describe the capabilities of these language servers. Co-authored-by: Alice Koreman <[email protected]>
1 parent c96106d commit e11c544

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

server/aws-lsp-json/src/language-server/jsonServer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const JsonServerFactory =
3636
const onInitializeHandler = () => {
3737
return {
3838
capabilities: {
39-
completionProvider: { resolveProvider: true },
39+
completionProvider: { resolveProvider: false },
4040
hoverProvider: true,
4141
documentFormattingProvider: true,
4242
textDocumentSync: {

server/aws-lsp-yaml/src/language-server/yamlServer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const YamlServerFactory =
3636
const onInitializeHandler = () => {
3737
return {
3838
capabilities: {
39-
completionProvider: { resolveProvider: true },
39+
completionProvider: { resolveProvider: false },
4040
hoverProvider: true,
4141
documentFormattingProvider: true,
4242
textDocumentSync: {

0 commit comments

Comments
 (0)