Skip to content

fix(amazonq): add jitter for websocket client re-connections #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix(amazonq): add jitter for websocket client re-connections #1752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/aws-lsp-codewhisperer/src/language-server/workspaceContext/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ export class WebSocketClient {
// Apply exponential backoff for both unclean closures and failed reconnection attempts
if (this.reconnectAttempts < this.maxReconnectAttempts) {
this.reconnectAttempts++
const delay = Math.min(1000 * Math.pow(2, this.reconnectAttempts), 30000)
const baseDelay = Math.min(1000 * Math.pow(2, this.reconnectAttempts), 30000)
const jitter = Math.random() * 5000 // jitter of 0 ~ 5000 milliseconds
Copy link
Contributor

@yzhangok yzhangok Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious where does this 5000 come from?

Copy link
Contributor Author

@LiGaCu LiGaCu Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an initially chosen value to distribute the potential surge traffic across 5 seconds.

We can tune this value in the future if needed.

const delay = baseDelay + jitter
this.logging.log(
`WebSocket will attempt reconnection ${this.reconnectAttempts}/${this.maxReconnectAttempts} in ${delay}s`
)
Expand Down
Loading