feat(amazonq): support context commands in agentic chat

[zixlin7]

Problem

We need to support files/folders/code symbols/prompts as context command in agentic chat, and also show user the context referenced in chat response

Solution

note telemetry update will be followup in next PR

related VS Code change: aws/aws-toolkit-vscode#6999

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[kmile]

Is this stub missing in TestFeatures?

[zixlin7]

yes I think so

[kmile]

nit: Why does promptsDirectory get its own handler ahd rulesDirectory does not?

[zixlin7]

because prompts are dynamically updated in the chat context menu, rules are just sent along with api requests

[kmile]

Why do we use relativePath for rules but filePath for prompts? Is there a meaningful distinction?

[zixlin7]

because rules are in the workspace but prompts are in the .aws folder

[kmile]

Does this have to be any[]? Is there no more specific type we can use here? It looks like we're using context in a pretty specific way inside mapToContextCommandItems, is that a type we can extract and use here?

[kmile]

I don't really get this method, instead of using any and converting it using this method, can't we use ContextCommandItem directly where we call this method?

The context: any always seems to have this type:

{ icon: 'file' | 'folder' | 'code-block' | string, command: string | undefined, id: string | undefined }

which combined with workspaceFolderPath is essentially the same as ContextCommandItem already.

This method maps the any to the specific type and filters out the known icons?

[zixlin7]

I think the main reason we have to do this is because context is missing type which is used in the call to get prompt from the local context server, but makes sense to create a type for it instead of using any, will follow up

[kmile]

We're using workspace.fs to access the filesystem, but in this case I think chokidar uses the underlying fs directly.

Could this use https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_didChangeWatchedFiles instead?

This could be a follow up, but it does render the agenticChat unusable in browser environments in the meantime.

[ege0zcan]

Tested in a lsp server-client example and by configuring the following code on the server only (no changes on the client) I was able to get it to work

connection.onInitialized(() => {
	// 1.a) build the folder URI
	const folderUri = URI.file(
		path.join(os.homedir(), '.aws', 'amazonq', 'prompts')
	).toString();

	// 1.b) register a watcher on “**/*” under that URI
	const options: DidChangeWatchedFilesRegistrationOptions = {
		watchers: [
			{
				globPattern: {
					baseUri: folderUri,
					pattern: '**/*',
				},
			} as FileSystemWatcher,
		],
	};

	// tell the client “please watch this!”
	connection.client.register(DidChangeWatchedFilesNotification.type, options);
});

connection.onDidChangeWatchedFiles((params) => {
	for (const evt of params.changes) {
		console.log(
			`File ${evt.uri} was ${['', 'created', 'changed', 'deleted'][evt.type]}`
		);
	}
});

[kmile]

Do we use this anywhere? It seems like we're just instantiating the class, and calling it in the Server (which is great, I much prefer that over singletons)

[zixlin7]

Ah I forgot to dispose it, fixed

[kmile]

What is the actual mechanism for sending context items to the client? I don't think I saw it in LocalProjectContextServer.

[zixlin7]

What is the actual mechanism for sending context items to the client? I don't think I saw it in LocalProjectContextServer.

it is send in ContextCommandsProvider here:

language-servers/server/aws-lsp-codewhisperer/src/language-server/agenticChat/context/contextCommandsProvider.ts

Line 71 in 98aa254

this.chat.sendContextCommands({ contextCommandGroups: allItems })

[avi-alpert]

the prompt file extension is .md, not .prompt.md