Skip to content

Commit 23027d6

Browse files
chore: Generate build artifacts for 2.8.3 release
1 parent 221f5da commit 23027d6

File tree

7 files changed

+17
-1774
lines changed

7 files changed

+17
-1774
lines changed

build_artifacts/v2/v2.8/v2.8.3/CHANGELOG-cpu.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

build_artifacts/v2/v2.8/v2.8.3/CHANGELOG-gpu.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

build_artifacts/v2/v2.8/v2.8.3/RELEASE.md

Lines changed: 0 additions & 69 deletions
This file was deleted.

build_artifacts/v2/v2.8/v2.8.3/cpu.env.out

Lines changed: 0 additions & 775 deletions
This file was deleted.

build_artifacts/v2/v2.8/v2.8.3/dirs/etc/sagemaker-ui/network_validation.sh

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -126,18 +126,14 @@ temp_dir=$(mktemp -d)
126126
# Launch all service API checks in parallel background jobs
127127
for service in "${!SERVICE_COMMANDS[@]}"; do
128128
{
129-
output_file="$temp_dir/${service}_output"
130-
131-
# Run command with timeout
132-
if timeout "${api_time_out_limit}s" bash -c "${SERVICE_COMMANDS[$service]}" > "$output_file" 2>&1; then
129+
# Run command with timeout, discard stdout/stderr
130+
if timeout "${api_time_out_limit}s" bash -c "${SERVICE_COMMANDS[$service]}" > /dev/null 2>&1; then
133131
# Success: write OK to temp file
134132
echo "OK" > "$temp_dir/$service"
135133
else
136134
# Get exit code to differentiate timeout or other errors
137135
exit_code=$?
138-
if grep -q "Could not connect to the endpoint URL" "$output_file"; then
139-
echo "UNREACHABLE" > "$temp_dir/$service"
140-
elif [ "$exit_code" -eq 124 ]; then
136+
if [ "$exit_code" -eq 124 ]; then
141137
# Timeout exit code
142138
echo "TIMEOUT" > "$temp_dir/$service"
143139
else
@@ -159,13 +155,10 @@ for service in "${!SERVICE_COMMANDS[@]}"; do
159155
if [[ "$result" == "TIMEOUT" ]]; then
160156
echo "$service API did NOT resolve within ${api_time_out_limit}s. Marking as unreachable."
161157
unreachable_services+=("$service")
162-
elif [[ "$result" == "UNREACHABLE" ]]; then
163-
echo "$service API failed to connect to the endpoint. Marking as unreachable."
164-
unreachable_services+=("$service")
165158
elif [[ "$result" == "OK" ]]; then
166159
echo "$service API is reachable."
167160
else
168-
echo "$service API returned an error (but not a timeout or endpoint reachability failure). Ignored for network check."
161+
echo "$service API returned an error (but not a timeout). Ignored for network check."
169162
fi
170163
else
171164
echo "$service check did not produce a result file. Skipping."

build_artifacts/v2/v2.8/v2.8.3/dirs/etc/sagemaker-ui/sagemaker_ui_post_startup.sh

Lines changed: 13 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -87,43 +87,22 @@ c.Application.logging_config = {
8787
EOT
8888
fi
8989

90-
# Add debug call to get domain info
91-
if [ ! -z "$dataZoneEndPoint" ]; then
92-
domain_response=$(aws datazone get-domain --debug --endpoint-url "$dataZoneEndPoint" --identifier "$dataZoneDomainId" --region "$dataZoneDomainRegion" 2>&1)
90+
# Setting this to +x to not log credentials from the response of fetching credentials.
91+
set +x
9392

94-
else
95-
domain_response=$(aws datazone get-domain --debug --identifier "$dataZoneDomainId" --region "$dataZoneDomainRegion" 2>&1)
96-
fi
97-
98-
# Check if domain is in express mode
99-
response_body=$(echo "$domain_response" | grep -A1 "Response body:" | tail -n1 | sed 's/^b'\''//;s/'\''$//')
100-
# Remove leading/trailing whitespace and the 'b' prefix
101-
cleaned_response=$(echo "$response_body" | sed 's/\\n//g')
102-
is_express_mode=$(echo "$cleaned_response" | jq -r '.preferences.DOMAIN_MODE == "EXPRESS"')
103-
104-
if [ "$is_express_mode" = "true" ]; then
105-
echo "Domain is in express mode. Using default credentials"
106-
# Use default credentials - no additional configuration needed
107-
aws configure set credential_source EcsContainer --profile DomainExecutionRoleCreds
108-
echo "Successfully configured DomainExecutionRoleCreds profile with default credentials"
109-
else
110-
echo "Domain is not in express mode"
111-
# Setting this to +x to not log credentials from the response of fetching credentials.
112-
set +x
113-
# Note: The $? check immediately follows the sagemaker-studio command to ensure we're checking its exit status.
114-
# Adding commands between these lines could lead to incorrect error handling.
115-
response=$(timeout 30 sagemaker-studio credentials get-domain-execution-role-credential-in-space --domain-id "$dataZoneDomainId" --profile default)
116-
responseStatus=$?
93+
# Note: The $? check immediately follows the sagemaker-studio command to ensure we're checking its exit status.
94+
# Adding commands between these lines could lead to incorrect error handling.
95+
response=$(timeout 30 sagemaker-studio credentials get-domain-execution-role-credential-in-space --domain-id "$dataZoneDomainId" --profile default)
96+
responseStatus=$?
11797

118-
set -x
98+
set -x
11999

120-
if [ $responseStatus -ne 0 ]; then
100+
if [ $responseStatus -ne 0 ]; then
121101
echo "Failed to fetch domain execution role credentials. Will skip adding new credentials profile: DomainExecutionRoleCreds."
122102
write_status_to_file "error" "Network issue detected. Your domain may be using a public subnet, which affects IDE functionality. Please contact your admin."
123-
else
103+
else
124104
aws configure set credential_process "sagemaker-studio credentials get-domain-execution-role-credential-in-space --domain-id $dataZoneDomainId --profile default" --profile DomainExecutionRoleCreds
125105
echo "Successfully configured DomainExecutionRoleCreds profile"
126-
fi
127106
fi
128107

129108
# Run AWS CLI command to get the username from DataZone User Profile.
@@ -200,7 +179,7 @@ mkdir -p "$HOME/.config" # Create config directory if it doesn't exist
200179
jq -n \
201180
--arg smusProjectDirectory "$SMUS_PROJECT_DIR" \
202181
--arg isGitProject "$IS_GIT_PROJECT" \
203-
'{
182+
'{
204183
smusProjectDirectory: $smusProjectDirectory,
205184
isGitProject: ($isGitProject == "true")
206185
}' > "$HOME/.config/smus-storage-metadata.json"
@@ -231,8 +210,8 @@ fi
231210

232211
# Generate sagemaker pysdk intelligent default config
233212
nohup python /etc/sagemaker/sm_pysdk_default_config.py &
234-
# Only run the following commands if SAGEMAKER_APP_TYPE_LOWERCASE is jupyterlab and domain is not in express mode
235-
if [ "${SAGEMAKER_APP_TYPE_LOWERCASE}" = "jupyterlab" ] && [ "$is_express_mode" != "true" ]; then
213+
# Only run the following commands if SAGEMAKER_APP_TYPE_LOWERCASE is jupyterlab
214+
if [ "${SAGEMAKER_APP_TYPE_LOWERCASE}" = "jupyterlab" ]; then
236215
# do not fail immediately for non-zero exit code returned
237216
# by start-workflows-container. An expected non-zero exit
238217
# code will be returned if there is not a minimum of 2
@@ -245,7 +224,7 @@ if [ "${SAGEMAKER_APP_TYPE_LOWERCASE}" = "jupyterlab" ] && [ "$is_express_mode"
245224

246225
# write unexpected error to file if any of the remaining scripts fail.
247226
trap 'write_status_to_file "error" "An unexpected error occurred. Please stop and restart your space to retry."' ERR
248-
227+
249228
# Install conda and pip dependencies if lib mgmt config existing
250229
bash /etc/sagemaker-ui/libmgmt/install-lib.sh
251230

0 commit comments

Comments
 (0)