Skip to content

Commit badbc01

Browse files
ruijiang-rjiantejaskashTejas Kashinath
authored
feat(workflows-local-runner-unifiedstorage): update start container script to reslove symlink and use its target for mount (#709)
Co-authored-by: Tejas Kashinath <[email protected]> Co-authored-by: Tejas Kashinath <[email protected]>
1 parent 31bc5a3 commit badbc01

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

template/v2/dirs/etc/sagemaker-ui/workflows/docker-compose.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ x-airflow-common: &airflow-common
4343
- /home/sagemaker-user/.workflows_setup/plugins:/usr/local/airflow/plugins
4444
- /home/sagemaker-user/.workflows_setup/requirements:/usr/local/airflow/requirements
4545
- /home/sagemaker-user/.workflows_setup/startup:/usr/local/airflow/startup
46-
- /home/sagemaker-user/src:/home/sagemaker-user/src:rw
46+
- ${MOUNT_DIR}:/home/sagemaker-user/src:rw
4747
- /home/sagemaker-user/jobs:/home/sagemaker-user/jobs:rw
4848
depends_on: &airflow-common-depends-on
4949
postgres:

template/v2/dirs/etc/sagemaker-ui/workflows/start-workflows-container.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ set -eu
33

44
# Get project directory based on storage type
55
PROJECT_DIR=${SMUS_PROJECT_DIR:-"$HOME/src"}
6+
if [ -z "$SMUS_PROJECT_DIR" ]; then
7+
MOUNT_DIR=$PROJECT_DIR
8+
else
9+
MOUNT_DIR=$(readlink -f "$PROJECT_DIR") # get the symlink source
10+
fi
611

712
# Datazone project metadata
813
RESOURCE_METADATA_FILE=/opt/ml/metadata/resource-metadata.json
@@ -178,6 +183,7 @@ cp -n "/etc/sagemaker-ui/workflows/sample_dag.py" "${WORKFLOW_DAG_PATH}/"
178183
aws ecr get-login-password --region ${AWS_REGION} | docker login --username AWS --password-stdin ${ECR_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com
179184

180185
PROJECT_DIR=$(basename $PROJECT_DIR) \
186+
MOUNT_DIR=$MOUNT_DIR \
181187
ECR_ACCOUNT_ID=$ECR_ACCOUNT_ID \
182188
ACCOUNT_ID=$AWS_ACCOUNT_ID \
183189
DZ_DOMAIN_ID=$DZ_DOMAIN_ID \

template/v3/dirs/etc/sagemaker-ui/workflows/docker-compose.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ x-airflow-common: &airflow-common
4343
- /home/sagemaker-user/.workflows_setup/plugins:/usr/local/airflow/plugins
4444
- /home/sagemaker-user/.workflows_setup/requirements:/usr/local/airflow/requirements
4545
- /home/sagemaker-user/.workflows_setup/startup:/usr/local/airflow/startup
46-
- /home/sagemaker-user/src:/home/sagemaker-user/src:rw
46+
- ${MOUNT_DIR}:/home/sagemaker-user/src:rw
4747
- /home/sagemaker-user/jobs:/home/sagemaker-user/jobs:rw
4848
depends_on: &airflow-common-depends-on
4949
postgres:

template/v3/dirs/etc/sagemaker-ui/workflows/start-workflows-container.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ set -eu
33

44
# Get project directory based on storage type
55
PROJECT_DIR=${SMUS_PROJECT_DIR:-"$HOME/src"}
6+
if [ -z "$SMUS_PROJECT_DIR" ]; then
7+
MOUNT_DIR=$PROJECT_DIR
8+
else
9+
MOUNT_DIR=$(readlink -f "$PROJECT_DIR") # get the symlink source
10+
fi
611

712
# Datazone project metadata
813
RESOURCE_METADATA_FILE=/opt/ml/metadata/resource-metadata.json
@@ -178,6 +183,7 @@ cp -n "/etc/sagemaker-ui/workflows/sample_dag.py" "${WORKFLOW_DAG_PATH}/"
178183
aws ecr get-login-password --region ${AWS_REGION} | docker login --username AWS --password-stdin ${ECR_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com
179184

180185
PROJECT_DIR=$(basename $PROJECT_DIR) \
186+
MOUNT_DIR=$MOUNT_DIR \
181187
ECR_ACCOUNT_ID=$ECR_ACCOUNT_ID \
182188
ACCOUNT_ID=$AWS_ACCOUNT_ID \
183189
DZ_DOMAIN_ID=$DZ_DOMAIN_ID \

0 commit comments

Comments
 (0)