Merge pull request #188 from leoroy/mix-case-fix

leoroy · web-flow · commit cbdb7ef80645 · 2023-05-02T18:10:47.000-07:00
fix: fix the trial-component loading issue for jobs with mix-case name
diff --git a/src/smexperiments/_environment.py b/src/smexperiments/_environment.py
@@ -78,7 +78,7 @@ def get_trial_component(self, sagemaker_boto_client):
         while time.time() - start < 300:
             summaries = list(
                 trial_component.TrialComponent.list(
-                    source_arn=self.source_arn.lower(), sagemaker_boto_client=sagemaker_boto_client
+                    source_arn=self.source_arn, sagemaker_boto_client=sagemaker_boto_client
                 )
             )
             if summaries:
diff --git a/tests/unit/test_environment.py b/tests/unit/test_environment.py
@@ -77,7 +77,7 @@ def test_resolve_trial_component(training_job_env, sagemaker_boto_client):
     tc = environment.get_trial_component(sagemaker_boto_client)
 
     assert trial_component_name == tc.trial_component_name
-    sagemaker_boto_client.list_trial_components.assert_called_with(SourceArn="arn:1234abcde")
+    sagemaker_boto_client.list_trial_components.assert_called_with(SourceArn="arn:1234aBcDe")
     sagemaker_boto_client.describe_trial_component.assert_called_with(TrialComponentName=trial_component_name)
 
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ def get_trial_component(self, sagemaker_boto_client):`
`78`	`78`	`while time.time() - start < 300:`
`79`	`79`	`summaries = list(`
`80`	`80`	`trial_component.TrialComponent.list(`
`81`		`- source_arn=self.source_arn.lower(), sagemaker_boto_client=sagemaker_boto_client`
	`81`	`+ source_arn=self.source_arn, sagemaker_boto_client=sagemaker_boto_client`
`82`	`82`	`)`
`83`	`83`	`)`
`84`	`84`	`if summaries:`