Skip to content

Commit 2bca582

Browse files
author
pintaoz
committed
Update tests
1 parent 1ec94a5 commit 2bca582

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/sagemaker/hyperpod/cli/commands/cluster_stack.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def parse_status_list(ctx, param, value):
5353
@click.argument("config-file", required=True)
5454
@click.argument("stack-name", required=True)
5555
@click.option("--region", help="AWS region")
56-
@click.option("--template-version", help="Version number of cluster creation template")
56+
@click.option("--template-version", type=click.INT, help="Version number of cluster creation template")
5757
@click.option("--debug", is_flag=True, help="Enable debug logging")
5858
def create_cluster_stack(config_file, region, template_version, debug):
5959
"""Create a new HyperPod cluster stack using the provided configuration.

test/integration_tests/cluster_management/test_hp_cluster_creation.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,7 @@ def test_configure_cluster(runner, cluster_name):
148148
"create-sagemaker-iam-role-stack": "true",
149149
"create-hyperpod-cluster-stack": "true",
150150
"create-helm-chart-stack": "true",
151-
"create-fsx-stack": "false",
152-
"template-version": "1"
151+
"create-fsx-stack": "false"
153152
}
154153

155154
# Build CLI arguments
@@ -171,8 +170,7 @@ def test_configure_cluster(runner, cluster_name):
171170
"create_sagemaker_iam_role_stack": True,
172171
"create_hyperpod_cluster_stack": True,
173172
"create_helm_chart_stack": True,
174-
"create_fsx_stack": False,
175-
"template-version": "1"
173+
"create_fsx_stack": False
176174
}
177175
assert_config_values("./", expected_config)
178176

@@ -192,7 +190,7 @@ def test_create_cluster(runner, cluster_name, create_time):
192190
# Record time before submission
193191
CREATE_TIME = datetime.now(timezone.utc)
194192

195-
result = runner.invoke(create, ["--region", REGION], catch_exceptions=False)
193+
result = runner.invoke(create, ["--region", REGION, "--template-version", "1"], catch_exceptions=False)
196194
assert_command_succeeded(result)
197195

198196
# Verify expected submission messages appear

0 commit comments

Comments
 (0)