Skip to content

Commit 4f73d26

Browse files
test: update unit-test for list jobs
1 parent d7c7d5c commit 4f73d26

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

test/unit_tests/test_job.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
1111
# ANY KIND, either express or implied. See the License for the specific
1212
# language governing permissions and limitations under the License.
13+
import json
1314
import unittest
1415
import click
1516
import subprocess
@@ -159,7 +160,7 @@ def test_list_job_happy_case(
159160
mock_list_training_job_service: mock.Mock,
160161
):
161162
mock_list_training_job_service.return_value = self.mock_list_jobs
162-
mock_list_training_job_service_and_list_jobs.return_value = {"jobs": []}
163+
mock_list_training_job_service_and_list_jobs.return_value = json.dumps({"jobs": []})
163164
result = self.runner.invoke(list_jobs)
164165
self.assertEqual(result.exit_code, 0)
165166
self.assertIn("jobs", result.output)
@@ -176,7 +177,7 @@ def test_list_job_happy_case_debug_mode(
176177
mock_list_training_job_service: mock.Mock,
177178
):
178179
mock_list_training_job_service.return_value = self.mock_list_jobs
179-
mock_list_training_job_service_and_list_jobs.return_value = {"jobs": []}
180+
mock_list_training_job_service_and_list_jobs.return_value = json.dumps({"jobs": []})
180181
result = self.runner.invoke(list_jobs, ["--debug"])
181182
self.assertEqual(result.exit_code, 0)
182183
self.assertIn("jobs", result.output)
@@ -192,7 +193,7 @@ def test_list_job_happy_case_with_namespace(
192193
mock_list_training_job_service: mock.Mock,
193194
):
194195
mock_list_training_job_service.return_value = self.mock_list_jobs
195-
mock_list_training_job_service_and_list_jobs.return_value = {"jobs": []}
196+
mock_list_training_job_service_and_list_jobs.return_value = json.dumps({"jobs": []})
196197
result = self.runner.invoke(list_jobs, ["--namespace", "kubeflow"])
197198
self.assertEqual(result.exit_code, 0)
198199
self.assertIn("jobs", result.output)
@@ -207,7 +208,7 @@ def test_list_job_happy_case_with_all_namespace(
207208
mock_list_training_job_service: mock.Mock,
208209
):
209210
mock_list_training_job_service.return_value = self.mock_list_jobs
210-
mock_list_training_job_service_and_list_jobs.return_value = {"jobs": []}
211+
mock_list_training_job_service_and_list_jobs.return_value = json.dumps({'jobs': []})
211212
result = self.runner.invoke(list_jobs, ["-A"])
212213
self.assertEqual(result.exit_code, 0)
213214
self.assertIn("jobs", result.output)
@@ -222,7 +223,7 @@ def test_list_job_happy_case_with_all_namespace_and_selector(
222223
mock_list_training_job_service: mock.Mock,
223224
):
224225
mock_list_training_job_service.return_value = self.mock_list_jobs
225-
mock_list_training_job_service_and_list_jobs.return_value = {"jobs": []}
226+
mock_list_training_job_service_and_list_jobs.return_value = json.dumps({"jobs": []})
226227
result = self.runner.invoke(list_jobs, ["-A", "-l", "test=test"])
227228
self.assertEqual(result.exit_code, 0)
228229
self.assertIn("jobs", result.output)

0 commit comments

Comments
 (0)