Add test_job test

Author: pintaoz

src/hyperpod_cli/service/list_training_jobs.py

@@ -18,6 +18,7 @@
 from hyperpod_cli.clients.kubernetes_client import (
     KubernetesClient,
 )
+from hyperpod_cli.utils import setup_logger
 from kubernetes.client.rest import ApiException
 from kubernetes.client import (
     V1ResourceAttributes
@@ -49,6 +50,8 @@ def list_training_jobs(
         k8s_client = KubernetesClient()
 
         jobs: List = []
+        logger = setup_logger(__name__)
+        logger.debug(namespace)
         try:
             if all_namespaces:
                 namespaces: List[str] = k8s_client.list_namespaces()

test/unit_tests/clients/test_kubernetes_client.py

@@ -662,26 +662,38 @@ def test_get_cluster_queue(
             name="test-cluster-queue",
         )
 
+    @patch("kubernetes.config.load_kube_config")
     @patch(
-        "kubernetes.client.CoreV1Api",
+        "kubernetes.client.CoreV1Api.read_namespace",
         return_value=Mock(
             read_namespace=Mock(
-                return_value=V1Namespace(metadata=V1ObjectMeta(name="test"))
+                return_value=V1Namespace(metadata=V1ObjectMeta(name="kubeflow"))
             )
         ),
     )
-    def test_check_if_namespace_exists_true(self, mock_core_client: Mock):
+    def test_check_if_namespace_exists_true(
+        self,
+        mock_core_client: Mock,
+        mock_kube_config: Mock,
+    ):
+        mock_kube_config.return_value = None
         test_client = KubernetesClient()
         result = test_client.check_if_namespace_exists("kubeflow")
         self.assertTrue(result)
 
+    @patch("kubernetes.config.load_kube_config")
     @patch(
-        "kubernetes.client.CoreV1Api",
+        "kubernetes.client.CoreV1Api.read_namespace",
         side_effect=client.rest.ApiException(
             status=404,
         ),
     )
-    def test_check_if_namespace_exists_false(self, mock_core_client: Mock):
+    def test_check_if_namespace_exists_false(
+        self, 
+        mock_core_client: Mock,
+        mock_kube_config: Mock,
+    ):
+        mock_kube_config.return_value = None
         test_client = KubernetesClient()
         result = test_client.check_if_namespace_exists("abcdef")
         self.assertFalse(result)

test/unit_tests/test_job.py

@@ -258,6 +258,18 @@ def test_list_job_when_subprocess_command_gives_exception(
             "Unexpected error happens when trying to list training job",
             result.output,
         )
+    
+    @mock.patch("hyperpod_cli.clients.kubernetes_client.KubernetesClient.__new__")
+    def test_list_job_when_namespace_not_exist(
+        self,
+        mock_kubernetes_client: mock.Mock,
+    ):
+        mock_client_instance = mock_kubernetes_client.return_value
+        mock_client_instance.check_if_namespace_exists.return_value = False
+        result = self.runner.invoke(list_jobs, ["--namespace", "abcdef"])
+        mock_client_instance.check_if_namespace_exists.assert_any_call("abcdef")
+        self.assertEqual(result.exit_code, 1)
+        self.assertIn("Namespace abcdef does not exist!", result.output)
 
     @mock.patch("hyperpod_cli.service.list_pods.ListPods")
     @mock.patch("hyperpod_cli.service.list_pods.ListPods.list_pods_for_training_job")