Update warning message string for k8s version compatibility check (#229)

* Update warning message string for k8s version compatibility check

**Description**
The warning message earlier was not formatted well enough. Made it explicitly look like a warning.

**Testing Done**
- Added unit test case to check if the warning will be displayed or not.
- Checking the warning color to be yellow.

Author: papriwal

src/sagemaker/hyperpod/common/utils.py

@@ -483,14 +483,12 @@ def verify_kubernetes_version_compatibility(logger) -> bool:
                 has_min_compatibility = True
 
                 # Check if client version is below minimum compatibility
-                if client_version[0] < min_major or (client_version[0] == min_major and client_version[1] < min_minor):
-                    logger.warning(
-                        f"Kubernetes version incompatibility detected! Your client version {client_version_str} "
-                        f"(package: {kubernetes_client_version}) is below the minimum compatible version {min_major}.{min_minor} "
-                        f"required by server {server_version_str}. The server explicitly requires a minimum client version."
-                    )
-                    logger.warning(
-                        f"To resolve this issue, please update your kubernetes Python client to meet the minimum requirement."
+                if client_version[0] < min_major or (client_version[0] == min_major and client_version[1] < min_minor):                    
+                    click.secho(
+                        f"\nWARNING: Kubernetes client version {client_version_str} is incompatible with server {server_version_str}. "
+                        f"Server requires minimum client version {min_major}.{min_minor}. "
+                        f"\nPlease update Kubernetes Python Client: pip install --upgrade kubernetes>={min_major}.{min_minor}.0",
+                        fg="yellow"
                     )
                     is_compatible = False
         except (ValueError, TypeError, AttributeError) as e:
@@ -500,15 +498,12 @@ def verify_kubernetes_version_compatibility(logger) -> bool:
         if not has_min_compatibility:
             # Fall back to standard compatibility check if min versions not provided
             server_version_parsed = (int(server_version_info.major), int(server_version_info.minor))
-            if not is_kubernetes_version_compatible(client_version, server_version_parsed):
-                logger.warning(
-                    f"Kubernetes version incompatibility detected! Your client version {client_version_str} "
-                    f"(package: {kubernetes_client_version}) is not compatible with server version {server_version_str}. "
-                    f"According to Kubernetes support policy, client should be within 3 minor versions behind "
-                    f"and not more than 1 minor version ahead of the server."
-                )
-                logger.warning(
-                    f"To resolve this issue, please update your kubernetes Python client to a compatible version."
+            if not is_kubernetes_version_compatible(client_version, server_version_parsed):                
+                click.secho(
+                    f"\nWARNING: Kubernetes client version {client_version_str} is incompatible with server {server_version_str}. "
+                    f"Client must be within 3 minor versions behind and not more than 1 ahead of server. "
+                    f"\nPlease update Kubernetes Python Client: pip install --upgrade kubernetes",
+                    fg="yellow"
                 )
                 is_compatible = False
 

test/unit_tests/common/test_utils.py

@@ -182,6 +182,95 @@ def test_is_kubernetes_version_compatible_default_versions(self):
         self.assertTrue(is_kubernetes_version_compatible((1, 24), (0, 0)))
         self.assertTrue(is_kubernetes_version_compatible((0, 0), (0, 0)))
 
+    @patch('click.secho')
+    @patch('kubernetes.client.VersionApi')
+    @patch('sagemaker.hyperpod.common.utils.kubernetes_client_version', '12.0.0')
+    def test_verify_kubernetes_version_compatibility_incompatible_min_version(self, mock_version_api, mock_secho):
+        """Test verify_kubernetes_version_compatibility with incompatible minimum version"""
+        # Mock server version info with minimum compatibility requirements
+        mock_server_info = MagicMock()
+        mock_server_info.major = '1'
+        mock_server_info.minor = '28'
+        mock_server_info.min_compatibility_major = '1'
+        mock_server_info.min_compatibility_minor = '25'
+        
+        mock_version_api_instance = MagicMock()
+        mock_version_api_instance.get_code.return_value = mock_server_info
+        mock_version_api.return_value = mock_version_api_instance
+        
+        mock_logger = MagicMock()
+        
+        from sagemaker.hyperpod.common.utils import verify_kubernetes_version_compatibility
+        result = verify_kubernetes_version_compatibility(mock_logger)
+        
+        # Should return False for incompatible versions
+        self.assertFalse(result)
+        
+        # Should call click.secho with yellow color for warning
+        mock_secho.assert_called_once()
+        call_args = mock_secho.call_args
+        self.assertIn('WARNING:', call_args[0][0])
+        self.assertIn('1.16 is incompatible with server 1.28', call_args[0][0])
+        self.assertEqual(call_args[1]['fg'], 'yellow')
+
+    @patch('click.secho')
+    @patch('kubernetes.client.VersionApi')
+    @patch('sagemaker.hyperpod.common.utils.kubernetes_client_version', '12.0.0')
+    def test_verify_kubernetes_version_compatibility_incompatible_standard_policy(self, mock_version_api, mock_secho):
+        """Test verify_kubernetes_version_compatibility with standard policy incompatibility"""
+        # Mock server version info without minimum compatibility requirements
+        mock_server_info = MagicMock()
+        mock_server_info.major = '1'
+        mock_server_info.minor = '28'
+        mock_server_info.min_compatibility_major = None
+        mock_server_info.min_compatibility_minor = None
+        
+        mock_version_api_instance = MagicMock()
+        mock_version_api_instance.get_code.return_value = mock_server_info
+        mock_version_api.return_value = mock_version_api_instance
+        
+        mock_logger = MagicMock()
+        
+        from sagemaker.hyperpod.common.utils import verify_kubernetes_version_compatibility
+        result = verify_kubernetes_version_compatibility(mock_logger)
+        
+        # Should return False for incompatible versions
+        self.assertFalse(result)
+        
+        # Should call click.secho with yellow color for warning
+        mock_secho.assert_called_once()
+        call_args = mock_secho.call_args
+        self.assertIn('WARNING:', call_args[0][0])
+        self.assertIn('1.16 is incompatible with server 1.28', call_args[0][0])
+        self.assertEqual(call_args[1]['fg'], 'yellow')
+
+    @patch('click.secho')
+    @patch('kubernetes.client.VersionApi')
+    @patch('sagemaker.hyperpod.common.utils.kubernetes_client_version', '24.0.0')
+    def test_verify_kubernetes_version_compatibility_compatible_no_warning(self, mock_version_api, mock_secho):
+        """Test verify_kubernetes_version_compatibility with compatible versions - no warning should show"""
+        # Mock server version info with compatible version
+        mock_server_info = MagicMock()
+        mock_server_info.major = '1'
+        mock_server_info.minor = '24'
+        mock_server_info.min_compatibility_major = None
+        mock_server_info.min_compatibility_minor = None
+        
+        mock_version_api_instance = MagicMock()
+        mock_version_api_instance.get_code.return_value = mock_server_info
+        mock_version_api.return_value = mock_version_api_instance
+        
+        mock_logger = MagicMock()
+        
+        from sagemaker.hyperpod.common.utils import verify_kubernetes_version_compatibility
+        result = verify_kubernetes_version_compatibility(mock_logger)
+        
+        # Should return True for compatible versions
+        self.assertTrue(result)
+        
+        # Should NOT call click.secho since no warning needed
+        mock_secho.assert_not_called()
+
     def test_is_eks_orchestrator_true(self):
         mock_client = MagicMock()
         mock_client.describe_cluster.return_value = {"Orchestrator": {"Eks": {}}}