Skip to content

Commit 04887c6

Browse files
author
Bryannah Hernandez
committed
dep fixes
1 parent 8302586 commit 04887c6

File tree

5 files changed

+32
-10
lines changed

5 files changed

+32
-10
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,6 @@
11
pyspark==3.3.1
22
sagemaker-feature-store-pyspark-3.3
3+
uvicorn>=0.30.1
4+
fastapi>=0.111.0
5+
nest-asyncio
6+
transformers

requirements/extras/huggingface_requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ sagemaker_schema_inference_artifacts>=0.0.5
33
uvicorn>=0.30.1
44
fastapi>=0.111.0
55
nest-asyncio
6-
transformers>=3.0.2
6+
transformers

requirements/extras/test_requirements.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,7 @@ schema==0.7.5
3939
tensorflow>=2.1,<=2.16
4040
mlflow>=2.12.2,<2.13
4141
huggingface_hub>=0.23.4
42+
uvicorn>=0.30.1
43+
fastapi>=0.111.0
44+
nest-asyncio
45+
transformers

src/sagemaker/serve/app.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,6 @@
99
from transformers import pipeline
1010
from fastapi import FastAPI, Request
1111

12-
if not importlib.util.find_spec("uvicorn"):
13-
raise ImportError("Unable to import uvicorn, check if uvicorn is installed")
14-
15-
if not importlib.util.find_spec("transformers"):
16-
raise ImportError("Unable to import transformers, check if transformers is installed")
17-
18-
if not importlib.util.find_spec("fastapi"):
19-
raise ImportError("Unable to import fastapi, check if fastapi is installed")
20-
2112

2213
logger = logging.getLogger(__name__)
2314

@@ -58,6 +49,15 @@ def post(payload: dict):
5849

5950
async def main():
6051
"""Running server locally with uvicorn"""
52+
if not importlib.util.find_spec("uvicorn"):
53+
raise ImportError("Unable to import uvicorn, check if uvicorn is installed")
54+
55+
if not importlib.util.find_spec("transformers"):
56+
raise ImportError("Unable to import transformers, check if transformers is installed")
57+
58+
if not importlib.util.find_spec("fastapi"):
59+
raise ImportError("Unable to import fastapi, check if fastapi is installed")
60+
6161
logger.info("Running")
6262
config = uvicorn.Config(
6363
"sagemaker.app:app",

tests/unit/sagemaker/serve/mode/test_in_process_mode.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,12 @@ def test_load_ex(self, mock_session, mock_inference_spec, mock_path):
9898
def test_create_server_happy(
9999
self, mock_session, mock_inference_spec, mock_predictor, mock_logger
100100
):
101+
mock_start_serving = Mock()
102+
mock_start_serving.side_effect = lambda *args, **kwargs: (
103+
True,
104+
None,
105+
)
106+
101107
mock_response = "Fake response"
102108
mock_multi_model_server_deep_ping = Mock()
103109
mock_multi_model_server_deep_ping.side_effect = lambda *args, **kwargs: (
@@ -114,6 +120,7 @@ def test_create_server_happy(
114120
)
115121

116122
in_process_mode._multi_model_server_deep_ping = mock_multi_model_server_deep_ping
123+
in_process_mode._start_serving = mock_start_serving
117124

118125
in_process_mode.create_server(predictor=mock_predictor)
119126

@@ -133,6 +140,12 @@ def test_create_server_ex(
133140
mock_inference_spec,
134141
mock_predictor,
135142
):
143+
mock_start_serving = Mock()
144+
mock_start_serving.side_effect = lambda *args, **kwargs: (
145+
True,
146+
None,
147+
)
148+
136149
mock_multi_model_server_deep_ping = Mock()
137150
mock_multi_model_server_deep_ping.side_effect = lambda *args, **kwargs: (
138151
False,
@@ -148,5 +161,6 @@ def test_create_server_ex(
148161
)
149162

150163
in_process_mode._multi_model_server_deep_ping = mock_multi_model_server_deep_ping
164+
in_process_mode._start_serving = mock_start_serving
151165

152166
self.assertRaises(LocalDeepPingException, in_process_mode.create_server, mock_predictor)

0 commit comments

Comments
 (0)