change: add deprecation warnings for estimator.delete_endpoint() and tuner.delete_endpoint() (#1644)

Author: laurenyu

src/sagemaker/estimator.py

@@ -826,6 +826,11 @@ def delete_endpoint(self):
         Raises:
             botocore.exceptions.ClientError: If the endpoint does not exist.
         """
+        logging.warning(
+            "estimator.delete_endpoint() will be deprecated in SageMaker Python SDK v2. "
+            "Please use the delete_endpoint() function on your predictor instead."
+        )
+
         self._ensure_latest_training_job(error_message="Endpoint was not created yet")
         self.sagemaker_session.delete_endpoint(self.latest_training_job.name)
 

src/sagemaker/tuner.py

@@ -840,6 +840,11 @@ def delete_endpoint(self, endpoint_name=None):
         Args:
             endpoint_name (str): Name of the endpoint to delete
         """
+        logging.warning(
+            "HyperparameterTuner.delete_endpoint() will be deprecated in SageMaker Python SDK v2. "
+            "Please use the delete_endpoint() function on your predictor instead."
+        )
+
         endpoint_name = endpoint_name or self.best_training_job()
         self.sagemaker_session.delete_endpoint(endpoint_name)
 

tests/unit/test_estimator.py

@@ -672,6 +672,25 @@ def test_delete_endpoint_without_endpoint(sagemaker_session):
     assert "Endpoint was not created yet" in str(error)
 
 
+def test_delete_endpoint_deprecation_warning(sagemaker_session, caplog):
+    fw = DummyFramework(
+        entry_point=SCRIPT_PATH,
+        role="DummyRole",
+        sagemaker_session=sagemaker_session,
+        train_instance_count=INSTANCE_COUNT,
+        train_instance_type=INSTANCE_TYPE,
+    )
+    fw.latest_training_job = Mock(name="job")
+
+    fw.delete_endpoint()
+
+    expected_warning = (
+        "estimator.delete_endpoint() will be deprecated in SageMaker Python SDK v2. "
+        "Please use the delete_endpoint() function on your predictor instead."
+    )
+    assert expected_warning in caplog.text
+
+
 def test_enable_cloudwatch_metrics(sagemaker_session):
     fw = DummyFramework(
         entry_point=SCRIPT_PATH,

tests/unit/test_tuner.py

@@ -911,6 +911,17 @@ def test_delete_endpoint(tuner):
     tuner.sagemaker_session.delete_endpoint.assert_called_with(JOB_NAME)
 
 
+def test_delete_endpoint_deprecation_warning(tuner, caplog):
+    tuner.best_training_job = Mock()
+    tuner.delete_endpoint()
+
+    expected_warning = (
+        "HyperparameterTuner.delete_endpoint() will be deprecated in SageMaker Python SDK v2. "
+        "Please use the delete_endpoint() function on your predictor instead."
+    )
+    assert expected_warning in caplog.text
+
+
 def test_fit_no_inputs(tuner, sagemaker_session):
     script_path = os.path.join(DATA_DIR, "mxnet_mnist", "failure_script.py")
     tuner.estimator = MXNet(