Skip to content

Commit 086b920

Browse files
authored
Merge branch 'master' into chore/telemetry-for-deployment-configs
2 parents 8f886fe + 732011e commit 086b920

File tree

8 files changed

+46
-10
lines changed

8 files changed

+46
-10
lines changed

.github/workflows/codeql.yml

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
name: "CodeQL"
2+
on:
3+
push:
4+
branches: [ "master" ]
5+
pull_request:
6+
branches: [ "master" ]
7+
schedule:
8+
- cron: '30 8 * * *'
9+
jobs:
10+
analyze:
11+
name: Analyze (${{ matrix.language }})
12+
runs-on: ${{ 'ubuntu-latest' }}
13+
permissions:
14+
security-events: write
15+
packages: read
16+
17+
strategy:
18+
matrix:
19+
include:
20+
- language: python
21+
build-mode: none
22+
- language: java-kotlin
23+
build-mode: none
24+
steps:
25+
- name: Checkout repository
26+
uses: actions/checkout@6ccd57f4c5d15bdc2fef309bd9fb6cc9db2ef1c6
27+
- name: Initialize CodeQL
28+
uses: github/codeql-action/init@4b1d7da102ff94aca014c0245062b1a463356d72
29+
with:
30+
languages: ${{ matrix.language }}
31+
build-mode: ${{ matrix.build-mode }}
32+
- name: Perform CodeQL Analysis
33+
uses: github/codeql-action/analyze@4b1d7da102ff94aca014c0245062b1a463356d72
34+
with:
35+
category: "/language:${{matrix.language}}"

src/sagemaker/fw_utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@
152152
"2.1.0",
153153
"2.1.2",
154154
"2.2.0",
155-
"2.3.0",
156155
"2.3.1",
157156
]
158157

src/sagemaker/image_uri_config/huggingface-llm.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -717,7 +717,7 @@
717717
"tag_prefix": "2.3.0-tgi2.2.0",
718718
"repository": "huggingface-pytorch-tgi-inference",
719719
"container_version": {
720-
"gpu": "cu121-ubuntu22.04"
720+
"gpu": "cu121-ubuntu22.04-v2.0"
721721
}
722722
}
723723
}

src/sagemaker/image_uri_config/pytorch-smp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"2.1": "2.1.2",
99
"2.2": "2.3.1",
1010
"2.2.0": "2.3.1",
11-
"2.3": "2.4.0"
11+
"2.3.1": "2.4.0"
1212
},
1313
"versions": {
1414
"2.0.1": {

tests/integ/test_sklearn.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,6 @@ def test_deploy_model(
159159
def test_deploy_model_with_serverless_inference_config(
160160
sklearn_training_job,
161161
sagemaker_session,
162-
sklearn_latest_version,
163-
sklearn_latest_py_version,
164162
):
165163
endpoint_name = unique_name_from_base("test-sklearn-deploy-model-serverless")
166164
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
@@ -173,7 +171,7 @@ def test_deploy_model_with_serverless_inference_config(
173171
model_data,
174172
ROLE,
175173
entry_point=script_path,
176-
framework_version=sklearn_latest_version,
174+
framework_version="1.0-1",
177175
sagemaker_session=sagemaker_session,
178176
)
179177
predictor = model.deploy(

tests/integ/test_xgboost.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,9 @@ def test_training_with_network_isolation(
121121
]
122122

123123

124-
@pytest.mark.skip(reason="re:Invent keynote3 blocker. Revisit after release")
125124
def test_xgboost_serverless_inference(
126125
xgboost_training_job,
127126
sagemaker_session,
128-
xgboost_latest_version,
129127
):
130128
endpoint_name = unique_name_from_base("test-xgboost-deploy-model-serverless")
131129
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
@@ -139,7 +137,7 @@ def test_xgboost_serverless_inference(
139137
model_data=model_data,
140138
role=ROLE,
141139
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
142-
framework_version=xgboost_latest_version,
140+
framework_version="1.5-1",
143141
)
144142

145143
xgboost.deploy(

tests/unit/sagemaker/image_uris/test_huggingface_llm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"2.0.0": "2.1.1-tgi2.0.0-gpu-py310-cu121-ubuntu22.04",
4343
"2.0.1": "2.1.1-tgi2.0.1-gpu-py310-cu121-ubuntu22.04",
4444
"2.0.2": "2.3.0-tgi2.0.2-gpu-py310-cu121-ubuntu22.04",
45-
"2.2.0": "2.3.0-tgi2.2.0-gpu-py310-cu121-ubuntu22.04",
45+
"2.2.0": "2.3.0-tgi2.2.0-gpu-py310-cu121-ubuntu22.04-v2.0",
4646
},
4747
"inf2": {
4848
"0.0.16": "1.13.1-optimum0.0.16-neuronx-py310-ubuntu22.04",

tests/unit/sagemaker/image_uris/test_smp_v2.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ def test_smp_v2(load_config):
2727
"torch_distributed": {"enabled": True},
2828
"smdistributed": {"modelparallel": {"enabled": True}},
2929
}
30+
3031
for processor in PROCESSORS:
3132
for version in VERSIONS:
3233
ACCOUNTS = load_config["training"]["versions"][version]["registries"]
@@ -38,6 +39,11 @@ def test_smp_v2(load_config):
3839
if "2.1" in version or "2.2" in version or "2.3" in version:
3940
cuda_vers = "cu121"
4041

42+
if "2.3.1" == version:
43+
py_version = "py311"
44+
45+
print(version, py_version)
46+
4147
uri = image_uris.get_training_image_uri(
4248
region,
4349
framework="pytorch",

0 commit comments

Comments
 (0)