feature: add mxnet 1.8 to image uris (#540)

Author: metrizable

src/sagemaker/image_uri_config/mxnet.json

@@ -8,7 +8,9 @@
             "1.2": "1.2.1",
             "1.3": "1.3.0",
             "1.4": "1.4.1",
-            "1.6": "1.6.0"
+            "1.6": "1.6.0",
+            "1.7": "1.7.0",
+            "1.8": "1.8.0"
         },
         "versions": {
             "0.12.1": {
@@ -310,6 +312,36 @@
                 },
                 "repository": "mxnet-training",
                 "py_versions": ["py3"]
+            },
+            "1.8.0": {
+                "registries": {
+                    "af-south-1": "626614931356",
+                    "ap-east-1": "871362719292",
+                    "ap-northeast-1": "763104351884",
+                    "ap-northeast-2": "763104351884",
+                    "ap-south-1": "763104351884",
+                    "ap-southeast-1": "763104351884",
+                    "ap-southeast-2": "763104351884",
+                    "ca-central-1": "763104351884",
+                    "cn-north-1": "727897471807",
+                    "cn-northwest-1": "727897471807",
+                    "eu-central-1": "763104351884",
+                    "eu-north-1": "763104351884",
+                    "eu-west-1": "763104351884",
+                    "eu-west-2": "763104351884",
+                    "eu-west-3": "763104351884",
+                    "eu-south-1": "692866216735",
+                    "me-south-1": "217643126080",
+                    "sa-east-1": "763104351884",
+                    "us-east-1": "763104351884",
+                    "us-east-2": "763104351884",
+                    "us-gov-west-1": "442386744353",
+                    "us-iso-east-1": "886529160074",
+                    "us-west-1": "763104351884",
+                    "us-west-2": "763104351884"
+                },
+                "repository": "mxnet-training",
+                "py_versions": ["py37"]
             }
         }
     },
@@ -624,6 +656,36 @@
                 },
                 "repository": "mxnet-inference",
                 "py_versions": ["py3"]
+            },
+            "1.8.0": {
+                "registries": {
+                    "af-south-1": "626614931356",
+                    "ap-east-1": "871362719292",
+                    "ap-northeast-1": "763104351884",
+                    "ap-northeast-2": "763104351884",
+                    "ap-south-1": "763104351884",
+                    "ap-southeast-1": "763104351884",
+                    "ap-southeast-2": "763104351884",
+                    "ca-central-1": "763104351884",
+                    "cn-north-1": "727897471807",
+                    "cn-northwest-1": "727897471807",
+                    "eu-central-1": "763104351884",
+                    "eu-north-1": "763104351884",
+                    "eu-west-1": "763104351884",
+                    "eu-west-2": "763104351884",
+                    "eu-west-3": "763104351884",
+                    "eu-south-1": "692866216735",
+                    "me-south-1": "217643126080",
+                    "sa-east-1": "763104351884",
+                    "us-east-1": "763104351884",
+                    "us-east-2": "763104351884",
+                    "us-gov-west-1": "442386744353",
+                    "us-iso-east-1": "886529160074",
+                    "us-west-1": "763104351884",
+                    "us-west-2": "763104351884"
+                },
+                "repository": "mxnet-inference",
+                "py_versions": ["py37"]
             }
         }
     },

tests/conftest.py

@@ -140,6 +140,8 @@ def chainer_py_version(request):
 def mxnet_inference_py_version(mxnet_inference_version, request):
     if Version(mxnet_inference_version) < Version("1.7.0"):
         return request.param
+    elif Version(mxnet_inference_version) == Version("1.8.0"):
+        return "py37"
     else:
         return "py3"
 
@@ -148,6 +150,8 @@ def mxnet_inference_py_version(mxnet_inference_version, request):
 def mxnet_training_py_version(mxnet_training_version, request):
     if Version(mxnet_training_version) < Version("1.7.0"):
         return request.param
+    elif Version(mxnet_training_version) == Version("1.8.0"):
+        return "py37"
     else:
         return "py3"
 

tests/unit/test_mxnet.py

@@ -664,9 +664,16 @@ def test_model_prepare_container_def_no_instance_type_or_image(
 
 
 def test_attach(sagemaker_session, mxnet_training_version, mxnet_training_py_version):
-    training_image = "1.dkr.ecr.us-west-2.amazonaws.com/sagemaker-mxnet-{0}-cpu:{1}-cpu-{0}".format(
-        mxnet_training_py_version, mxnet_training_version
-    )
+    if mxnet_training_py_version == "py37":
+        training_image = "1.dkr.ecr.us-west-2.amazonaws.com/mxnet-training:{1}-cpu-{0}".format(
+            mxnet_training_py_version, mxnet_training_version
+        )
+    else:
+        training_image = (
+            "1.dkr.ecr.us-west-2.amazonaws.com/sagemaker-mxnet-{0}-cpu:{1}-cpu-{0}".format(
+                mxnet_training_py_version, mxnet_training_version
+            )
+        )
     returned_job_description = {
         "AlgorithmSpecification": {"TrainingInputMode": "File", "TrainingImage": training_image},
         "HyperParameters": {