Skip to content

Commit 1743273

Browse files
fix: sensitive values will not be logged
1 parent 937acaa commit 1743273

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/sagemaker/config/config_utils.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,15 @@ def _log_sagemaker_config_single_substitution(source_value, config_value, config
7272
source_value_log_copy = deepcopy(source_value)
7373
config_value_log_copy = deepcopy(config_value)
7474

75-
7675
if isinstance(source_value_log_copy, dict):
7776
for key in source_value_log_copy.keys():
78-
if re.search(r'(secret|password|key)', key, re.IGNORECASE):
77+
if re.search(r'(secret|password|key|token)', key, re.IGNORECASE):
7978
source_value_log_copy[key] = '***'
8079

8180
if isinstance(config_value_log_copy, dict):
82-
for k in config_value_log_copy.keys():
83-
if re.search(r'(secret|password|key)', k, re.IGNORECASE):
84-
config_value_log_copy[k] = '***'
81+
for key in config_value_log_copy.keys():
82+
if re.search(r'(secret|password|key|token)', key, re.IGNORECASE):
83+
config_value_log_copy[key] = '***'
8584

8685
if config_value is not None:
8786

@@ -138,7 +137,7 @@ def _log_sagemaker_config_single_substitution(source_value, config_value, config
138137
)
139138
else:
140139
# nothing was specified in the config and nothing is being automatically applied
141-
logger.debug("Skipped value VALUE because no value defined\n config key = %s, source_value = %s", config_key_path, source_value_log_copy)
140+
logger.debug("Skipped value because no value defined\n config key = %s", config_key_path)
142141

143142

144143
def _log_sagemaker_config_merge(
@@ -214,7 +213,7 @@ def _log_sagemaker_config_merge(
214213

215214
else:
216215
# nothing was specified in the config and nothing is being automatically applied
217-
logger.debug("Skipped value NO SOURCE because no value defined\n config key = %s", config_key_path)
216+
logger.debug("Skipped value because no value defined\n config key = %s", config_key_path)
218217

219218

220219
def non_repeating_log_factory(logger: logging.Logger, method: str, cache_size=100) -> Callable:

0 commit comments

Comments
 (0)