fix: prevent false positive PR test results (#783)

Author: jesterhazy

buildspec.yml

@@ -17,36 +17,21 @@ phases:
       # run unit tests
       - AWS_ACCESS_KEY_ID= AWS_SECRET_ACCESS_KEY= AWS_SESSION_TOKEN=
         AWS_CONTAINER_CREDENTIALS_RELATIVE_URI= AWS_DEFAULT_REGION=
-        tox -e py27,py36 -- tests/unit
+        tox -e py36,py27 -- tests/unit
 
       # run notebook test
       - |
         if has-matching-changes "src/*.py" "setup.py" "setup.cfg"; then
           echo "running notebook test"
-          python setup.py sdist
-          aws s3 --region us-west-2 cp ./dist/sagemaker-*.tar.gz s3://sagemaker-python-sdk-pr/sagemaker.tar.gz
-          aws s3 cp s3://sagemaker-mead-cli/mead-nb-test.tar.gz mead-nb-test.tar.gz
-          tar -xzf mead-nb-test.tar.gz
-          git clone --depth 1 https://github.com/awslabs/amazon-sagemaker-examples.git
-          JAVA_HOME=$(get-java-home)
-          echo "set JAVA_HOME=$JAVA_HOME"
-          SAGEMAKER_ROLE_ARN=$(get-sagemaker-role-arn)
-          echo "set SAGEMAKER_ROLE_ARN=$SAGEMAKER_ROLE_ARN"
-          ./runtime/bin/mead-run-nb-test \
-            --instance-type ml.c4.8xlarge \
-            --region us-west-2 \
-            --lifecycle-config-name install-python-sdk \
-            --notebook-instance-role-arn $SAGEMAKER_ROLE_ARN \
-            ./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_distributed_mnist/tensorflow_batch_transform_mnist.ipynb
+          ./tests/scripts/run-notebook-test.sh
          else
            echo "skipping notebook test"
          fi
 
       # run integration tests
       - |
         if has-matching-changes "tests/" "src/*.py" "setup.py" "setup.cfg"; then
-          IGNORE_COVERAGE=- tox -e py36 -- tests/integ -n 24 --boxed --reruns 2
-          IGNORE_COVERAGE=- tox -e py27 -- tests/integ -n 24 --boxed --reruns 2
+          IGNORE_COVERAGE=- tox -e py36,py27 -- tests/integ -n 24 --boxed --reruns 2
         else
           echo "skipping integration tests"
         fi

tests/scripts/run-notebook-test.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+#
+# Run a test against a SageMaker notebook
+# Only runs within the SDK's CI/CD environment
+
+set -euo pipefail
+
+python setup.py sdist
+aws s3 --region us-west-2 cp ./dist/sagemaker-*.tar.gz s3://sagemaker-python-sdk-pr/sagemaker.tar.gz
+aws s3 cp s3://sagemaker-mead-cli/mead-nb-test.tar.gz mead-nb-test.tar.gz
+tar -xzf mead-nb-test.tar.gz
+git clone --depth 1 https://github.com/awslabs/amazon-sagemaker-examples.git
+JAVA_HOME=$(get-java-home)
+echo "set JAVA_HOME=$JAVA_HOME"
+SAGEMAKER_ROLE_ARN=$(get-sagemaker-role-arn)
+echo "set SAGEMAKER_ROLE_ARN=$SAGEMAKER_ROLE_ARN"
+./runtime/bin/mead-run-nb-test \
+--instance-type ml.c4.8xlarge \
+--region us-west-2 \
+--lifecycle-config-name install-python-sdk \
+--notebook-instance-role-arn $SAGEMAKER_ROLE_ARN \
+./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_distributed_mnist/tensorflow_batch_transform_mnist.ipynb