Skip to content

Commit 2edb2e6

Browse files
author
Jonathan Makunga
committed
Relax set deployment error handling
1 parent ba3d49c commit 2edb2e6

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

src/sagemaker/jumpstart/factory/model.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -674,11 +674,7 @@ def _add_config_name_to_init_kwargs(kwargs: JumpStartModelInitKwargs) -> JumpSta
674674
resolved_config = specs.inference_configs.configs[kwargs.config_name].resolved_config
675675
supported_instance_types = resolved_config.get("supported_inference_instance_types", [])
676676
if kwargs.instance_type not in supported_instance_types:
677-
raise ValueError(
678-
f"Instance type {kwargs.instance_type} "
679-
f"is not supported for config {kwargs.config_name}."
680-
)
681-
677+
JUMPSTART_LOGGER.warning("Overriding instance type to %s", kwargs.instance_type)
682678
return kwargs
683679

684680

tests/unit/sagemaker/jumpstart/model/test_model.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1941,12 +1941,6 @@ def test_model_set_deployment_config_incompatible_instance_type_or_name(
19411941
mock_get_model_specs.reset_mock()
19421942
mock_model_deploy.reset_mock()
19431943
mock_get_model_specs.side_effect = get_prototype_spec_with_configs
1944-
with pytest.raises(ValueError) as error:
1945-
model.set_deployment_config("neuron-inference", "ml.inf2.32xlarge")
1946-
assert (
1947-
"Instance type ml.inf2.32xlarge is not supported for config neuron-inference."
1948-
in str(error)
1949-
)
19501944

19511945
with pytest.raises(ValueError) as error:
19521946
model.set_deployment_config("neuron-inference-unknown-name", "ml.inf2.32xlarge")

0 commit comments

Comments
 (0)