Skip to content

Commit 3ad5961

Browse files
committed
Skip tests failing due to TF-IO
1 parent 8690405 commit 3ad5961

File tree

6 files changed

+47
-4
lines changed

6 files changed

+47
-4
lines changed

tests/integ/sagemaker/workflow/test_model_create_and_registration.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525

2626
import pytest
2727

28+
from packaging.version import Version
29+
from packaging.specifiers import SpecifierSet
30+
2831
from sagemaker.model_card.model_card import ModelCard, ModelOverview, ModelPackageModelCard
2932
from sagemaker.model_card.schema_constraints import ModelCardStatusEnum
3033
import tests
@@ -1250,6 +1253,11 @@ def test_model_registration_with_tensorflow_model_with_pipeline_model(
12501253
pipeline_name,
12511254
region_name,
12521255
):
1256+
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
1257+
pytest.skip(
1258+
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
1259+
"https://github.com/tensorflow/io/issues/2039"
1260+
)
12531261
base_dir = os.path.join(DATA_DIR, "tensorflow_mnist")
12541262
entry_point = os.path.join(base_dir, "mnist_v2.py")
12551263
input_path = sagemaker_session_for_pipeline.upload_data(

tests/integ/sagemaker/workflow/test_model_steps.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717

1818
import pytest
1919

20+
from packaging.version import Version
21+
from packaging.specifiers import SpecifierSet
22+
2023
from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution
2124
from sagemaker.workflow.fail_step import FailStep
2225
from sagemaker.workflow.functions import Join
@@ -589,6 +592,11 @@ def test_model_registration_with_drift_check_baselines_and_model_metrics(
589592
def test_model_registration_with_tensorflow_model_with_pipeline_model(
590593
pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name
591594
):
595+
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
596+
pytest.skip(
597+
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
598+
"https://github.com/tensorflow/io/issues/2039"
599+
)
592600
base_dir = os.path.join(DATA_DIR, "tensorflow_mnist")
593601
entry_point = os.path.join(base_dir, "mnist_v2.py")
594602
input_path = pipeline_session.upload_data(

tests/integ/sagemaker/workflow/test_training_steps.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818

1919
import pytest
2020

21+
from packaging.version import Version
22+
from packaging.specifiers import SpecifierSet
23+
2124
from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution
2225
from sagemaker import TrainingInput, get_execution_role, utils, image_uris
2326
from sagemaker.debugger import (
@@ -235,6 +238,12 @@ def test_training_step_with_output_path_as_join(
235238
def test_tensorflow_training_step_with_parameterized_code_input(
236239
pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name
237240
):
241+
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
242+
pytest.skip(
243+
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
244+
"https://github.com/tensorflow/io/issues/2039"
245+
)
246+
238247
base_dir = os.path.join(DATA_DIR, "tensorflow_mnist")
239248
entry_point1 = "mnist_v2.py"
240249
entry_point2 = "mnist_dummy.py"

tests/integ/test_transformer.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818

1919
import pytest
2020

21+
from packaging.version import Version
22+
from packaging.specifiers import SpecifierSet
23+
2124
from sagemaker import KMeans, s3, get_execution_role
2225
from sagemaker.mxnet import MXNet
2326
from sagemaker.pytorch import PyTorchModel
@@ -553,6 +556,12 @@ def test_transform_mxnet_logs(
553556
def test_transform_tf_kms_network_isolation(
554557
sagemaker_session, cpu_instance_type, tmpdir, tf_full_version, tf_full_py_version
555558
):
559+
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
560+
pytest.skip(
561+
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
562+
"https://github.com/tensorflow/io/issues/2039"
563+
)
564+
556565
data_path = os.path.join(DATA_DIR, "tensorflow_mnist")
557566

558567
tf = TensorFlow(

tests/unit/sagemaker/tensorflow/test_estimator.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
from mock import patch, Mock, MagicMock
2020
from packaging import version
21+
from packaging.version import Version
22+
from packaging.specifiers import SpecifierSet
2123
import pytest
2224

2325
from sagemaker.estimator import _TrainingJob
@@ -554,9 +556,14 @@ def test_fit_mwms(
554556

555557
expected_train_args = _create_train_job(framework_version, py_version=py_version)
556558
expected_train_args["input_config"][0]["DataSource"]["S3DataSource"]["S3Uri"] = inputs
557-
expected_train_args["image_uri"] = (
558-
f"763104351884.dkr.ecr.{REGION}.amazonaws.com/tensorflow-training:{framework_version}-cpu-{py_version}"
559-
)
559+
if Version(framework_version) in SpecifierSet("==2.16.*"):
560+
expected_train_args["image_uri"] = (
561+
f"763104351884.dkr.ecr.{REGION}.amazonaws.com/tensorflow-training:2.16-cpu-{py_version}"
562+
)
563+
else:
564+
expected_train_args["image_uri"] = (
565+
f"763104351884.dkr.ecr.{REGION}.amazonaws.com/tensorflow-training:{framework_version}-cpu-{py_version}"
566+
)
560567
expected_train_args["job_name"] = f"tensorflow-training-{TIMESTAMP}"
561568
expected_train_args["hyperparameters"][TensorFlow.LAUNCH_MWMS_ENV_NAME] = json.dumps(True)
562569
expected_train_args["hyperparameters"]["sagemaker_job_name"] = json.dumps(

tests/unit/test_processing.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
import pytest
1919
from mock import Mock, patch, MagicMock
2020
from packaging import version
21+
from packaging.version import Version
22+
from packaging.specifiers import SpecifierSet
2123

2224
from sagemaker import LocalSession
2325
from sagemaker.dataset_definition.inputs import (
@@ -507,7 +509,7 @@ def test_tensorflow_processor_with_required_parameters(
507509
else:
508510
tensorflow_image_uri = (
509511
"763104351884.dkr.ecr.us-west-2.amazonaws.com/tensorflow-training:{}-cpu-{}"
510-
).format(tensorflow_training_version, tensorflow_training_py_version)
512+
).format("2.16" if Version(tensorflow_training_version) in SpecifierSet("==2.16.*") else tensorflow_training_version, tensorflow_training_py_version)
511513

512514
expected_args["app_specification"]["ImageUri"] = tensorflow_image_uri
513515

0 commit comments

Comments
 (0)