Sniping fix for S3 bucket

Author: nargokul

src/sagemaker/session.py

@@ -630,13 +630,13 @@ def _create_s3_bucket_if_it_does_not_exist(self, bucket_name, region):
             s3 = self.s3_resource
 
         bucket = s3.Bucket(name=bucket_name)
+        expected_bucket_owner_id = self.account_id()
+
         if bucket.creation_date is None:
             self.general_bucket_check_if_user_has_permission(bucket_name, s3, bucket, region, True)
-
+            self.expected_bucket_owner_id_bucket_check(bucket_name, s3, expected_bucket_owner_id)
         elif self._default_bucket_set_by_sdk:
             self.general_bucket_check_if_user_has_permission(bucket_name, s3, bucket, region, False)
-
-            expected_bucket_owner_id = self.account_id()
             self.expected_bucket_owner_id_bucket_check(bucket_name, s3, expected_bucket_owner_id)
 
     def expected_bucket_owner_id_bucket_check(self, bucket_name, s3, expected_bucket_owner_id):

tests/unit/test_default_bucket.py

@@ -13,6 +13,7 @@
 from __future__ import absolute_import
 
 import datetime
+import unittest
 from unittest.mock import Mock
 
 import pytest
@@ -173,3 +174,31 @@ def test_bucket_creation_other_error(sagemaker_session):
 
         sagemaker_session.default_bucket()
     assert sagemaker_session._default_bucket is None
+
+
+def test_default_bucket_s3_create_call_creation_date(sagemaker_session):
+    error = ClientError(
+        error_response={"Error": {"Code": "403", "Message": "Forbidden"}},
+        operation_name="foo",
+    )
+    sagemaker_session.boto_session.resource("s3").meta.client.head_bucket.side_effect = Mock(
+        side_effect=error
+    )
+
+    with pytest.raises(ClientError):
+        sagemaker_session.default_bucket()
+
+
+def test_default_bucket_s3_create_call_default_bucket_set_by_sdk(sagemaker_session):
+    sagemaker_session._default_bucket_set_by_sdk = True
+    sagemaker_session.boto_session.resource("s3").Bucket().creation_date = 1733509801
+    error = ClientError(
+        error_response={"Error": {"Code": "403", "Message": "Forbidden"}},
+        operation_name="foo",
+    )
+    sagemaker_session.boto_session.resource("s3").meta.client.head_bucket.side_effect = Mock(
+        side_effect=error
+    )
+
+    with pytest.raises(ClientError):
+        sagemaker_session.default_bucket()