Skip to content

Commit 5570442

Browse files
author
Jonathan Makunga
committed
workers flags not needed when reload is set to true.
1 parent e89940e commit 5570442

File tree

2 files changed

+1
-23
lines changed

2 files changed

+1
-23
lines changed

src/sagemaker/serve/app.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ def _create_server(self):
7474
log_level="info",
7575
loop="asyncio",
7676
reload=True,
77-
workers=3,
7877
use_colors=True,
7978
)
8079

@@ -91,11 +90,7 @@ def start_server(self):
9190

9291
def stop_server(self):
9392
"""Destroys the uvicorn server."""
94-
if self.is_running:
95-
logger.info("Deleting server...")
96-
# self._stop_event.set()
97-
# self._thread.join()
98-
logger.info("Server deleted.")
93+
# TODO: Implement me.
9994

10095
def _start_run_async_in_thread(self):
10196
loop = asyncio.new_event_loop()
@@ -104,6 +99,3 @@ def _start_run_async_in_thread(self):
10499

105100
async def _serve(self):
106101
await self.server.serve()
107-
108-
def is_running(self):
109-
return self._thread is not None and self._thread.is_alive()

src/sagemaker/serve/model_server/multi_model_server/server.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
from __future__ import absolute_import
44

5-
import asyncio
65
import json
7-
import threading
86

97
import requests
108
import logging
@@ -28,20 +26,9 @@
2826
class InProcessMultiModelServer:
2927
"""In Process Mode Multi Model server instance"""
3028

31-
def __init__(self):
32-
# from sagemaker.serve.app import InProcessServer
33-
# self._in_process_server = InProcessServer
34-
pass
35-
36-
# def run_async_in_thread(self):
37-
# loop = asyncio.new_event_loop()
38-
# asyncio.set_event_loop(loop)
39-
# loop.run_until_complete(self.main())
40-
4129
def _start_serving(self):
4230
"""Initializes the start of the server"""
4331
from sagemaker.serve.app import InProcessServer
44-
# threading.Thread(target=self.run_async_in_thread, daemon=True).start()
4532
if hasattr(self, "inference_spec"):
4633
model_id = self.inference_spec.get_model()
4734
else:
@@ -58,7 +45,6 @@ def _invoke_multi_model_server_serving(self, request: bytes, content_type: str,
5845
"""Placeholder docstring"""
5946
try:
6047
response = requests.post(
61-
# "http://127.0.0.1:9007/generate",
6248
f"http://{self.server.host}:{self.server.port}/generate",
6349
data=request,
6450
headers={"Content-Type": content_type, "Accept": accept},

0 commit comments

Comments
 (0)