Skip to content

Commit 5cd2aa2

Browse files
authored
fix: skip efs tests in non us-west-2 regions (#1003)
1 parent 0d74efb commit 5cd2aa2

File tree

3 files changed

+38
-6
lines changed

3 files changed

+38
-6
lines changed

tests/integ/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@
7171
NO_LDA_REGIONS = ["eu-west-3", "eu-north-1", "sa-east-1", "ap-east-1"]
7272
NO_MARKET_PLACE_REGIONS = ["eu-west-3", "eu-north-1", "sa-east-1", "ap-east-1"]
7373

74+
EFS_TEST_ENABLED_REGION = ["us-west-2"]
75+
7476
logging.getLogger("boto3").setLevel(logging.INFO)
7577
logging.getLogger("botocore").setLevel(logging.INFO)
7678

tests/integ/test_kmeans_efs_fsx.py

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@
1414

1515
import pytest
1616

17+
import tests.integ
1718
from sagemaker import KMeans
1819
from sagemaker.amazon.amazon_estimator import FileSystemRecordSet
1920
from sagemaker.parameter import IntegerParameter, CategoricalParameter
2021
from sagemaker.tuner import HyperparameterTuner
2122
from sagemaker.utils import unique_name_from_base
2223
from tests.integ import TRAINING_DEFAULT_TIMEOUT_MINUTES, TUNING_DEFAULT_TIMEOUT_MINUTES
23-
from tests.integ.s3_utils import assert_s3_files_exist
2424
from tests.integ.file_system_input_utils import set_up_efs_fsx, tear_down
25+
from tests.integ.s3_utils import assert_s3_files_exist
2526
from tests.integ.timeout import timeout
2627

2728
TRAIN_INSTANCE_TYPE = "ml.c4.xlarge"
@@ -45,7 +46,10 @@ def efs_fsx_setup(sagemaker_session):
4546
tear_down(sagemaker_session, fs_resources)
4647

4748

48-
@pytest.mark.canary_quick
49+
@pytest.mark.skipif(
50+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
51+
reason="EFS integration tests need to be fixed before running in all regions.",
52+
)
4953
def test_kmeans_efs(efs_fsx_setup, sagemaker_session):
5054
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
5155
subnets = [efs_fsx_setup.subnet_id]
@@ -76,7 +80,10 @@ def test_kmeans_efs(efs_fsx_setup, sagemaker_session):
7680
assert_s3_files_exist(sagemaker_session, model_path, ["model.tar.gz"])
7781

7882

79-
@pytest.mark.canary_quick
83+
@pytest.mark.skipif(
84+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
85+
reason="EFS integration tests need to be fixed before running in all regions.",
86+
)
8087
def test_kmeans_fsx(efs_fsx_setup, sagemaker_session):
8188
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
8289
subnets = [efs_fsx_setup.subnet_id]
@@ -107,6 +114,10 @@ def test_kmeans_fsx(efs_fsx_setup, sagemaker_session):
107114
assert_s3_files_exist(sagemaker_session, model_path, ["model.tar.gz"])
108115

109116

117+
@pytest.mark.skipif(
118+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
119+
reason="EFS integration tests need to be fixed before running in all regions.",
120+
)
110121
def test_tuning_kmeans_efs(efs_fsx_setup, sagemaker_session):
111122
subnets = [efs_fsx_setup.subnet_id]
112123
security_group_ids = efs_fsx_setup.security_group_ids
@@ -163,6 +174,10 @@ def test_tuning_kmeans_efs(efs_fsx_setup, sagemaker_session):
163174
assert best_training_job
164175

165176

177+
@pytest.mark.skipif(
178+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
179+
reason="EFS integration tests need to be fixed before running in all regions.",
180+
)
166181
def test_tuning_kmeans_fsx(efs_fsx_setup, sagemaker_session):
167182
subnets = [efs_fsx_setup.subnet_id]
168183
security_group_ids = efs_fsx_setup.security_group_ids

tests/integ/test_tf_efs_fsx.py

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,15 @@
1717

1818
import pytest
1919

20+
import tests.integ
2021
from sagemaker.inputs import FileSystemInput
2122
from sagemaker.parameter import IntegerParameter
2223
from sagemaker.tensorflow import TensorFlow
2324
from sagemaker.tuner import HyperparameterTuner
2425
from sagemaker.utils import unique_name_from_base
2526
from tests.integ import TRAINING_DEFAULT_TIMEOUT_MINUTES, TUNING_DEFAULT_TIMEOUT_MINUTES
26-
from tests.integ.s3_utils import assert_s3_files_exist
2727
from tests.integ.file_system_input_utils import tear_down, set_up_efs_fsx
28+
from tests.integ.s3_utils import assert_s3_files_exist
2829
from tests.integ.timeout import timeout
2930

3031
RESOURCE_PATH = os.path.join(os.path.dirname(__file__), "..", "data")
@@ -48,7 +49,10 @@ def efs_fsx_setup(sagemaker_session):
4849
tear_down(sagemaker_session, fs_resources)
4950

5051

51-
@pytest.mark.canary_quick
52+
@pytest.mark.skipif(
53+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
54+
reason="EFS integration tests need to be fixed before running in all regions.",
55+
)
5256
def test_mnist_efs(efs_fsx_setup, sagemaker_session):
5357
role = efs_fsx_setup.role_name
5458
subnets = [efs_fsx_setup.subnet_id]
@@ -81,7 +85,10 @@ def test_mnist_efs(efs_fsx_setup, sagemaker_session):
8185
)
8286

8387

84-
@pytest.mark.canary_quick
88+
@pytest.mark.skipif(
89+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
90+
reason="EFS integration tests need to be fixed before running in all regions.",
91+
)
8592
def test_mnist_lustre(efs_fsx_setup, sagemaker_session):
8693
role = efs_fsx_setup.role_name
8794
subnets = [efs_fsx_setup.subnet_id]
@@ -114,6 +121,10 @@ def test_mnist_lustre(efs_fsx_setup, sagemaker_session):
114121
)
115122

116123

124+
@pytest.mark.skipif(
125+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
126+
reason="EFS integration tests need to be fixed before running in all regions.",
127+
)
117128
def test_tuning_tf_script_mode_efs(efs_fsx_setup, sagemaker_session):
118129
role = efs_fsx_setup.role_name
119130
subnets = [efs_fsx_setup.subnet_id]
@@ -158,6 +169,10 @@ def test_tuning_tf_script_mode_efs(efs_fsx_setup, sagemaker_session):
158169
assert best_training_job
159170

160171

172+
@pytest.mark.skipif(
173+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
174+
reason="EFS integration tests need to be fixed before running in all regions.",
175+
)
161176
def test_tuning_tf_script_mode_lustre(efs_fsx_setup, sagemaker_session):
162177
role = efs_fsx_setup.role_name
163178
subnets = [efs_fsx_setup.subnet_id]

0 commit comments

Comments
 (0)