Skip to content

Commit 6fb3223

Browse files
author
Malav Shastri
committed
Address comments: only add is_hub_content to user aggent suffix if its available
1 parent 2f07130 commit 6fb3223

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

src/sagemaker/jumpstart/hub/hub.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,10 @@ def __init__(
7878
"""
7979
self.hub_name = hub_name
8080
self.region = sagemaker_session.boto_region_name
81-
self._sagemaker_session = sagemaker_session or utils.get_default_jumpstart_session_with_user_agent_suffix(is_hub_content=True)
81+
self._sagemaker_session = (
82+
sagemaker_session
83+
or utils.get_default_jumpstart_session_with_user_agent_suffix(is_hub_content=True)
84+
)
8285
self.hub_storage_location = self._generate_hub_storage_location(bucket_name)
8386

8487
def _fetch_hub_bucket_name(self) -> str:

src/sagemaker/jumpstart/utils.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,12 +1022,15 @@ def get_jumpstart_user_agent_extra_suffix(
10221022

10231023
if os.getenv(constants.ENV_VARIABLE_DISABLE_JUMPSTART_TELEMETRY, None):
10241024
headers = sagemaker_python_sdk_headers
1025-
elif model_id is None and model_version is None:
1026-
headers = f"{sagemaker_python_sdk_headers} {hub_specific_suffix}"
1025+
elif is_hub_content is True:
1026+
if model_id is None and model_version is None:
1027+
headers = f"{sagemaker_python_sdk_headers} {hub_specific_suffix}"
1028+
else:
1029+
headers = (
1030+
f"{sagemaker_python_sdk_headers} {jumpstart_specific_suffix} {hub_specific_suffix}"
1031+
)
10271032
else:
1028-
headers = (
1029-
f"{sagemaker_python_sdk_headers} {jumpstart_specific_suffix} {hub_specific_suffix}"
1030-
)
1033+
headers = f"{sagemaker_python_sdk_headers} {jumpstart_specific_suffix}"
10311034

10321035
return headers
10331036

tests/unit/sagemaker/jumpstart/test_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1716,11 +1716,11 @@ def test_get_jumpstart_user_agent_extra_suffix(self, mock_getenv):
17161716
mock_getenv.return_value = False
17171717
assert utils.get_jumpstart_user_agent_extra_suffix(
17181718
"some-id", "some-version", "False"
1719-
).endswith("md/js_model_id#some-id md/js_model_ver#some-version md/js_is_hub_content#False")
1719+
).endswith("md/js_model_id#some-id md/js_model_ver#some-version")
17201720
mock_getenv.return_value = None
17211721
assert utils.get_jumpstart_user_agent_extra_suffix(
17221722
"some-id", "some-version", "False"
1723-
).endswith("md/js_model_id#some-id md/js_model_ver#some-version md/js_is_hub_content#False")
1723+
).endswith("md/js_model_id#some-id md/js_model_ver#some-version")
17241724
mock_getenv.return_value = "True"
17251725
assert not utils.get_jumpstart_user_agent_extra_suffix(
17261726
"some-id", "some-version", "True"

0 commit comments

Comments
 (0)