Skip to content

Commit 7768e52

Browse files
authored
fix: don't try to use local output path for KMS key in Local Mode (#1516)
1 parent 04e73bf commit 7768e52

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/sagemaker/estimator.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1722,11 +1722,14 @@ def _stage_user_code_in_s3(self):
17221722
code_bucket = self.sagemaker_session.default_bucket()
17231723
code_s3_prefix = "{}/{}".format(self._current_job_name, "source")
17241724
kms_key = None
1725-
17261725
elif self.code_location is None:
17271726
code_bucket, _ = parse_s3_url(self.output_path)
17281727
code_s3_prefix = "{}/{}".format(self._current_job_name, "source")
17291728
kms_key = self.output_kms_key
1729+
elif local_mode:
1730+
code_bucket, key_prefix = parse_s3_url(self.code_location)
1731+
code_s3_prefix = "/".join(filter(None, [key_prefix, self._current_job_name, "source"]))
1732+
kms_key = None
17301733
else:
17311734
code_bucket, key_prefix = parse_s3_url(self.code_location)
17321735
code_s3_prefix = "/".join(filter(None, [key_prefix, self._current_job_name, "source"]))

tests/integ/test_local_mode.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@ def test_mxnet_training_failure(sagemaker_local_session, mxnet_full_version, tmp
361361
train_instance_count=1,
362362
train_instance_type="local",
363363
sagemaker_session=sagemaker_local_session,
364+
code_location="s3://{}".format(sagemaker_local_session.default_bucket()),
364365
output_path="file://{}".format(tmpdir),
365366
)
366367

0 commit comments

Comments
 (0)