Skip to content

Commit 7ce89df

Browse files
authored
change: remove hardcoded creds from integ test (#1030)
1 parent 1316b63 commit 7ce89df

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/integ/test_git.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ def test_git_support_with_pytorch(sagemaker_local_session):
8484

8585

8686
@pytest.mark.local_mode
87+
@pytest.mark.skip("needs a secure authentication approach")
8788
def test_git_support_with_mxnet(sagemaker_local_session):
88-
8989
script_path = "mnist.py"
9090
data_path = os.path.join(DATA_DIR, "mxnet_mnist")
9191
git_config = {
@@ -94,7 +94,7 @@ def test_git_support_with_mxnet(sagemaker_local_session):
9494
"commit": PRIVATE_COMMIT,
9595
"2FA_enabled": False,
9696
"username": "git-support-test",
97-
"password": "passw0rd@ %",
97+
"password": "", # TODO: find a more secure approach
9898
}
9999
source_dir = "mxnet"
100100
dependencies = ["foo/bar.py"]

0 commit comments

Comments
 (0)