Skip to content

Commit 90006f6

Browse files
author
Malav Shastri
committed
fix failing tests
1 parent 38495dc commit 90006f6

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

tests/unit/sagemaker/jumpstart/model/test_model.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1360,6 +1360,7 @@ def test_attach(
13601360
model_id="model-id",
13611361
model_version="model-version",
13621362
sagemaker_session=DEFAULT_JUMPSTART_SAGEMAKER_SESSION,
1363+
hub_name=None,
13631364
)
13641365
assert isinstance(val, JumpStartModel)
13651366

tests/unit/sagemaker/jumpstart/test_utils.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1714,21 +1714,21 @@ class TestUserAgent:
17141714
@patch("sagemaker.jumpstart.utils.os.getenv")
17151715
def test_get_jumpstart_user_agent_extra_suffix(self, mock_getenv):
17161716
mock_getenv.return_value = False
1717-
assert utils.get_jumpstart_user_agent_extra_suffix("some-id", "some-version").endswith(
1718-
"md/js_model_id#some-id md/js_model_ver#some-version"
1719-
)
1717+
assert utils.get_jumpstart_user_agent_extra_suffix(
1718+
"some-id", "some-version", "False"
1719+
).endswith("md/js_model_id#some-id md/js_model_ver#some-version md/js_is_hub_content#False")
17201720
mock_getenv.return_value = None
1721-
assert utils.get_jumpstart_user_agent_extra_suffix("some-id", "some-version").endswith(
1722-
"md/js_model_id#some-id md/js_model_ver#some-version"
1723-
)
1721+
assert utils.get_jumpstart_user_agent_extra_suffix(
1722+
"some-id", "some-version", "False"
1723+
).endswith("md/js_model_id#some-id md/js_model_ver#some-version md/js_is_hub_content#False")
17241724
mock_getenv.return_value = "True"
1725-
assert not utils.get_jumpstart_user_agent_extra_suffix("some-id", "some-version").endswith(
1726-
"md/js_model_id#some-id md/js_model_ver#some-version"
1727-
)
1725+
assert not utils.get_jumpstart_user_agent_extra_suffix(
1726+
"some-id", "some-version", "True"
1727+
).endswith("md/js_model_id#some-id md/js_model_ver#some-version md/js_is_hub_content#True")
17281728
mock_getenv.return_value = True
1729-
assert not utils.get_jumpstart_user_agent_extra_suffix("some-id", "some-version").endswith(
1730-
"md/js_model_id#some-id md/js_model_ver#some-version"
1731-
)
1729+
assert not utils.get_jumpstart_user_agent_extra_suffix(
1730+
"some-id", "some-version", "True"
1731+
).endswith("md/js_model_id#some-id md/js_model_ver#some-version md/js_is_hub_content#True")
17321732

17331733
@patch("sagemaker.jumpstart.utils.botocore.session")
17341734
@patch("sagemaker.jumpstart.utils.botocore.config.Config")
@@ -1748,7 +1748,7 @@ def test_get_default_jumpstart_session_with_user_agent_suffix(
17481748
utils.get_default_jumpstart_session_with_user_agent_suffix("model_id", "model_version")
17491749
mock_boto3_session.get_session.assert_called_once_with()
17501750
mock_get_jumpstart_user_agent_extra_suffix.assert_called_once_with(
1751-
"model_id", "model_version"
1751+
"model_id", "model_version", False
17521752
)
17531753
mock_botocore_config.assert_called_once_with(
17541754
user_agent_extra=mock_get_jumpstart_user_agent_extra_suffix.return_value

0 commit comments

Comments
 (0)