renaming functions

Author: Bryannah Hernandez

src/sagemaker/serve/builder/requirements_manager.py

@@ -22,7 +22,7 @@
 class RequirementsManager:
     """Manages dependency installation by detecting file types"""
 
-    def detect_file_exists(self, dependencies: str = None) -> str:
+    def capture_and_install_dependencies(self, dependencies: str = None) -> str:
         """Detects the type of file dependencies will be installed from
 
         If a req.txt or conda.yml file is provided, it verifies their existence and
@@ -34,7 +34,7 @@ def detect_file_exists(self, dependencies: str = None) -> str:
         Returns:
             file path of the existing or generated dependencies file
         """
-        dependencies = self._capture_from_local_runtime()
+        dependencies = self._detect_conda_env_and_local_dependencies()
 
         # Dependencies specified as either req.txt or conda_env.yml
         if dependencies.endswith(".txt"):
@@ -47,7 +47,7 @@ def detect_file_exists(self, dependencies: str = None) -> str:
     def _install_requirements_txt(self):
         """Install requirements.txt file using pip"""
         logger.info("Running command to pip install")
-        subprocess.run("pip install -r requirements.txt", shell=True, check=True)
+        subprocess.run("pip install -r in_process_requirements.txt", shell=True, check=True)
         logger.info("Command ran successfully")
 
     def _update_conda_env_in_path(self):
@@ -64,7 +64,7 @@ def _get_active_conda_env_prefix(self) -> str:
         """Returns the conda prefix from the set environment variable. None otherwise."""
         return os.getenv("CONDA_PREFIX")
 
-    def _capture_from_local_runtime(self) -> str:
+    def _detect_conda_env_and_local_dependencies(self) -> str:
         """Generates dependencies list from the user's local runtime.
 
         Raises RuntimeEnvironmentError if not able to.

src/sagemaker/serve/builder/transformers_builder.py

@@ -387,6 +387,6 @@ def _create_conda_env(self):
         """Creating conda environment by running commands"""
 
         try:
-            RequirementsManager().detect_file_exists(self)
+            RequirementsManager().capture_and_install_dependencies(self)
         except subprocess.CalledProcessError:
             print("Failed to create and activate conda environment.")

src/sagemaker/serve/utils/in_process_requirements.txt

@@ -1,17 +1,3 @@
-bzip2=1.0.8
-ca-certificates=2023.01.10
-libffi=3.4.2
-ncurses=6.4
-openssl=1.1.1t
-pip=23.0.1
-python=3.10.10
-readline=8.2
-setuptools=66.0.0
-sqlite=3.41.2
-tk=8.6.12
-wheel=0.38.4
-xz=5.2.10
-zlib=1.2.13
 altair>=4.2.2
 anyio>=3.6.2
 awscli>=1.27.114
@@ -27,7 +13,7 @@ contextlib2>=21.6.0
 decorator>=5.1.1
 dill>=0.3.6
 docutils>=0.16
- entrypoints>=0.4
+entrypoints>=0.4
 filelock>=3.11.0
 gitdb>=4.0.10
 gitpython>=3.1.31
@@ -93,3 +79,7 @@ tzlocal>=4.3
 urllib3>=1.26.15
 validators>=0.20.0
 zipp>=3.15.0
+uvicorn>=0.30.1
+fastapi>=0.111.0
+nest-asyncio
+transformers

tests/unit/sagemaker/serve/builder/test_requirements_manager.py

@@ -27,31 +27,34 @@ class TestRequirementsManager(unittest.TestCase):
         "sagemaker.serve.builder.requirements_manager.RequirementsManager._install_requirements_txt"
     )
     @patch(
-        "sagemaker.serve.builder.requirements_manager.RequirementsManager._capture_from_local_runtime"
+        "sagemaker.serve.builder.requirements_manager.RequirementsManager._detect_conda_env_and_local_dependencies"
     )
-    def test_detect_file_exists(
+    def test_capture_and_install_dependencies(
         self,
-        mock_capture_from_local_runtime,
+        mock_detect_conda_env_and_local_dependencies,
         mock_install_requirements_txt,
         mock_update_conda_env_in_path,
     ) -> str:
 
-        mock_capture_from_local_runtime.side_effect = lambda: ".txt"
-        RequirementsManager().detect_file_exists()
+        mock_detect_conda_env_and_local_dependencies.side_effect = lambda: ".txt"
+        RequirementsManager().capture_and_install_dependencies()
         mock_install_requirements_txt.assert_called_once()
 
-        mock_capture_from_local_runtime.side_effect = lambda: ".yml"
-        RequirementsManager().detect_file_exists()
+        mock_detect_conda_env_and_local_dependencies.side_effect = lambda: ".yml"
+        RequirementsManager().capture_and_install_dependencies()
         mock_update_conda_env_in_path.assert_called_once()
 
     @patch(
-        "sagemaker.serve.builder.requirements_manager.RequirementsManager._capture_from_local_runtime"
+        "sagemaker.serve.builder.requirements_manager.RequirementsManager._detect_conda_env_and_local_dependencies"
     )
-    def test_detect_file_exists_fail(self, mock__capture_from_local_runtime) -> str:
+    def test_capture_and_install_dependencies_fail(
+        self, mock_detect_conda_env_and_local_dependencies
+    ) -> str:
         mock_dependencies = "mock.ini"
-        mock__capture_from_local_runtime.side_effect = lambda: "invalid requirement"
+        mock_detect_conda_env_and_local_dependencies.side_effect = lambda: "invalid requirement"
         self.assertRaises(
-            ValueError, lambda: RequirementsManager().detect_file_exists(mock_dependencies)
+            ValueError,
+            lambda: RequirementsManager().capture_and_install_dependencies(mock_dependencies),
         )
 
     @patch("sagemaker.serve.builder.requirements_manager.logger")
@@ -63,7 +66,7 @@ def test_install_requirements_txt(self, mock_subprocess, mock_logger):
         calls = [call("Running command to pip install"), call("Command ran successfully")]
         mock_logger.info.assert_has_calls(calls)
         mock_subprocess.run.assert_called_once_with(
-            "pip install -r requirements.txt", shell=True, check=True
+            "pip install -r in_process_requirements.txt", shell=True, check=True
         )
 
     @patch("sagemaker.serve.builder.requirements_manager.logger")