fix integ test

Author: bencrabtree

src/sagemaker/jumpstart/estimator.py

@@ -41,7 +41,7 @@
     validate_model_id_and_get_type,
     resolve_model_sagemaker_config_field,
     verify_model_region_and_return_specs,
-    remove_env_var_from_estimator_kwargs_if_accept_eula_present,
+    remove_env_var_from_estimator_kwargs_if_model_access_config_present,
     get_model_access_config,
     get_hub_access_config,
 )
@@ -714,7 +714,7 @@ def fit(
             config_name=self.config_name,
             hub_access_config=self.hub_access_config,
         )
-        remove_env_var_from_estimator_kwargs_if_accept_eula_present(self.init_kwargs, accept_eula)
+        remove_env_var_from_estimator_kwargs_if_model_access_config_present(self.init_kwargs, self.model_access_config)
 
         return super(JumpStartEstimator, self).fit(**estimator_fit_kwargs.to_kwargs_dict())
 

src/sagemaker/jumpstart/utils.py

@@ -1632,16 +1632,16 @@ def get_draft_model_content_bucket(provider: Dict, region: str) -> str:
     return neo_bucket
 
 
-def remove_env_var_from_estimator_kwargs_if_accept_eula_present(
-    init_kwargs: dict, accept_eula: Optional[bool]
+def remove_env_var_from_estimator_kwargs_if_model_access_config_present(
+    init_kwargs: dict, model_access_config: dict | None
 ):
-    """Remove env vars if access configs are used
+    """Remove env vars if ModelAccessConfig is used
 
     Args:
         init_kwargs (dict): Dictionary of kwargs when Estimator is instantiated.
         accept_eula (Optional[bool]): Whether or not the EULA was accepted, optionally passed in to Estimator.fit().
     """
-    if accept_eula is not None and init_kwargs.get("environment") is not None:
+    if model_access_config is not None and init_kwargs.get("environment") is not None:
         if (
             constants.SAGEMAKER_GATED_MODEL_S3_URI_TRAINING_ENV_VAR_KEY
             in init_kwargs["environment"]
@@ -1672,7 +1672,7 @@ def get_model_access_config(accept_eula: Optional[bool], environment: Optional[d
         accept_eula (Optional[bool]): Whether or not the EULA was accepted, optionally passed in to Estimator.fit().
     """
     env_var_eula = environment.get("accept_eula") if environment else None
-    if env_var_eula and accept_eula is not None:
+    if env_var_eula is not None and accept_eula is not None:
         raise ValueError(
             "Cannot pass in both accept_eula and environment variables. "
             "Please remove the environment variable and pass in the accept_eula parameter."

src/test.py

@@ -0,0 +1,36 @@
+from sagemaker.jumpstart.hub.hub import Hub
+from sagemaker import hyperparameters
+from sagemaker.session import Session
+from sagemaker.jumpstart.estimator import JumpStartEstimator
+
+
+hub = Hub(hub_name="temp-bencrab-hub", sagemaker_session=Session())
+
+# hub.create(description="hello haha")
+
+model_id = "meta-vlm-llama-3-2-11b-vision"
+model_version = "*"
+hub_arn = hub.hub_name
+
+my_hyperparameters = hyperparameters.retrieve_default(
+    model_id=model_id, model_version=model_version, hub_arn=hub_arn
+)
+print(my_hyperparameters)
+hyperparameters.validate(
+    model_id=model_id,
+    model_version=model_version,
+    hyperparameters=my_hyperparameters,
+    hub_arn=hub_arn,
+)
+estimator = JumpStartEstimator(
+    model_id=model_id,
+    hub_name=hub_arn,
+    model_version=model_version,
+    environment={"accept_eula": "true"},  # Please change {"accept_eula": "true"}
+    disable_output_compression=True,
+    instance_type="ml.p4d.24xlarge",
+    hyperparameters=my_hyperparameters,
+)
+estimator.fit(
+    {"training": "s3://jumpstart-cache-prod-us-west-2/training-datasets/docVQA-small-3000ex/"}
+)