fix: upgrade pylint and fix tagging with SageMaker models (#732)

* Fix pylint and tagging with SageMaker models

pylint version we are currently using is buggy and we are not getting any
results back.

This change also fixes a bug where we are not actually passing the tags
parameter into the create_model call in the session.

* Use positional arg

Author: icywang86rui

src/sagemaker/analytics.py

@@ -63,7 +63,6 @@ def dataframe(self, force_refresh=False):
     def _fetch_dataframe(self):
         """Sub-class must calculate the dataframe and return it.
         """
-        pass
 
     def clear_cache(self):
         """Clear the object of all local caches of API methods, so

src/sagemaker/estimator.py

@@ -152,7 +152,6 @@ def train_image(self):
         Returns:
             str: The URI of the Docker image.
         """
-        pass
 
     @abstractmethod
     def hyperparameters(self):
@@ -164,7 +163,6 @@ def hyperparameters(self):
         Returns:
             dict[str, str]: The hyperparameters.
         """
-        pass
 
     def enable_network_isolation(self):
         """Return True if this Estimator will need network isolation to run.
@@ -405,7 +403,6 @@ def create_model(self, **kwargs):
         Returns:
             sagemaker.model.Model: A SageMaker ``Model`` object. See :func:`~sagemaker.model.Model` for full details.
         """
-        pass
 
     @classmethod
     def _prepare_init_params_from_job_description(cls, job_details, model_channel_name=None):

src/sagemaker/job.py

@@ -42,13 +42,11 @@ def start_new(self, estimator, inputs):
         Returns:
             sagemaker.job: Constructed object that captures all information about the started job.
         """
-        pass
 
     @abstractmethod
     def wait(self):
         """Wait for the Amazon SageMaker job to finish.
         """
-        pass
 
     @staticmethod
     def _load_config(inputs, estimator, expand_role=True, validate_uri=True):

src/sagemaker/local/data.py

@@ -97,7 +97,6 @@ def get_file_list(self):
         Returns:
              List[str]: List of absolute paths.
         """
-        pass
 
     @abstractmethod
     def get_root_dir(self):
@@ -106,7 +105,6 @@ def get_root_dir(self):
         Returns:
             str: absolute path to the root directory of this data source.
         """
-        pass
 
 
 class LocalFileDataSource(DataSource):
@@ -201,7 +199,6 @@ def split(self, file):
         Returns:
             generator for the individual records that were split from the file
         """
-        pass
 
 
 class NoneSplitter(Splitter):
@@ -286,7 +283,6 @@ def pad(self, file, size):
         Returns:
             generator of records
         """
-        pass
 
 
 class MultiRecordStrategy(BatchStrategy):

src/sagemaker/model.py

@@ -116,7 +116,8 @@ def _create_sagemaker_model(self, instance_type, accelerator_type=None, tags=Non
         enable_network_isolation = self.enable_network_isolation()
         self.sagemaker_session.create_model(self.name, self.role,
                                             container_def, vpc_config=self.vpc_config,
-                                            enable_network_isolation=enable_network_isolation)
+                                            enable_network_isolation=enable_network_isolation,
+                                            tags=tags)
 
     def _framework(self):
         return getattr(self, '__framework_name__', None)
@@ -254,7 +255,7 @@ def deploy(self, initial_instance_count, instance_type, accelerator_type=None, e
         if self._is_compiled_model:
             self.name += compiled_model_suffix
 
-        self._create_sagemaker_model(instance_type, accelerator_type)
+        self._create_sagemaker_model(instance_type, accelerator_type, tags)
         production_variant = sagemaker.production_variant(self.name, instance_type, initial_instance_count,
                                                           accelerator_type=accelerator_type)
         if endpoint_name:

tests/unit/test_estimator.py

@@ -909,7 +909,8 @@ def test_fit_deploy_keep_tags(sagemaker_session):
         'DummyRole',
         {'ModelDataUrl': 's3://bucket/model.tar.gz', 'Environment': {}, 'Image': 'fakeimage'},
         enable_network_isolation=False,
-        vpc_config=None)
+        vpc_config=None,
+        tags=tags)
 
 
 def test_generic_to_fit_no_input(sagemaker_session):

tox.ini

@@ -69,7 +69,7 @@ commands = flake8
 [testenv:pylint]
 basepython = python3
 deps =
-    pylint==2.1.1
+    pylint==2.3.1
 commands =
     python -m pylint --rcfile=.pylintrc -j 0 src/sagemaker