fix: model.transformer() passes tags to create_model() (#976)

* fix: model.transformer() passes tags to create_model()

* ignore kwargs in ModelPackage.create_sagemaker_model

Author: jesterhazy

src/sagemaker/model.py

@@ -498,7 +498,7 @@ def transformer(
             volume_kms_key (str): Optional. KMS key ID for encrypting the volume
                 attached to the ML compute instance (default: None).
         """
-        self._create_sagemaker_model(instance_type)
+        self._create_sagemaker_model(instance_type, tags=tags)
         if self.enable_network_isolation():
             env = None
 
@@ -895,11 +895,14 @@ def _is_marketplace(self):
                 return True
         return False
 
-    def _create_sagemaker_model(self, *args):  # pylint: disable=unused-argument
+    def _create_sagemaker_model(self, *args, **kwargs):  # pylint: disable=unused-argument
         """Create a SageMaker Model Entity
 
         Args:
-            *args: Arguments coming from the caller. This class does not require
+            args: Positional arguments coming from the caller. This class does not require
+                any so they are ignored.
+
+            kwargs: Keyword arguments coming from the caller. This class does not require
                 any so they are ignored.
         """
         if self.algorithm_arn:

tests/unit/test_model.py

@@ -361,16 +361,20 @@ def test_model_create_transformer(sagemaker_session):
         return_value=DESCRIBE_MODEL_PACKAGE_RESPONSE
     )
 
+    tags = [{"Key": "k", "Value": "v"}]
     model = DummyFrameworkModel(sagemaker_session=sagemaker_session)
+    instance_type = "ml.m4.xlarge"
     model.name = "auto-generated-model"
     transformer = model.transformer(
-        instance_count=1, instance_type="ml.m4.xlarge", env={"test": True}
+        instance_count=1, instance_type=instance_type, env={"test": True}, tags=tags
     )
     assert isinstance(transformer, sagemaker.transformer.Transformer)
     assert transformer.model_name == "auto-generated-model"
     assert transformer.instance_type == "ml.m4.xlarge"
     assert transformer.env == {"test": True}
 
+    sagemaker.model.Model._create_sagemaker_model.assert_called_with(instance_type, tags=tags)
+
 
 def test_model_package_enable_network_isolation_with_no_product_id(sagemaker_session):
     sagemaker_session.sagemaker_client.describe_model_package = Mock(