Skip to content

Commit c05abf0

Browse files
committed
fix: fix tests due to latest server-side validations (#284)
* fix: remove entrypoint due to latest validation * fix: accommodate None NetworkConfig in (Default)ModelMonitor.attach()
1 parent edfb9db commit c05abf0

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/sagemaker/model_monitor/model_monitoring.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,9 +1512,16 @@ def attach(cls, monitor_schedule_name, sagemaker_session=None):
15121512
"MonitoringJobDefinition"
15131513
].get("NetworkConfig")
15141514

1515-
vpc_config = schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"][
1516-
"NetworkConfig"
1517-
].get("VpcConfig")
1515+
vpc_config = None
1516+
if (
1517+
schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"].get(
1518+
"NetworkConfig"
1519+
)
1520+
is not None
1521+
):
1522+
vpc_config = schedule_desc["MonitoringScheduleConfig"]["MonitoringJobDefinition"][
1523+
"NetworkConfig"
1524+
].get("VpcConfig")
15181525

15191526
security_group_ids = None
15201527
if vpc_config is not None:

tests/integ/test_model_monitor.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ def byoc_monitoring_schedule_name(sagemaker_session, output_kms_key, volume_kms_
192192
),
193193
instance_count=INSTANCE_COUNT,
194194
instance_type=INSTANCE_TYPE,
195-
entrypoint=["/opt/program/analyze"],
196195
volume_size_in_gb=VOLUME_SIZE_IN_GB,
197196
volume_kms_key=volume_kms_key,
198197
output_kms_key=output_kms_key,
@@ -1649,7 +1648,6 @@ def test_byoc_monitor_suggest_baseline_and_create_monitoring_schedule_with_custo
16491648
),
16501649
instance_count=INSTANCE_COUNT,
16511650
instance_type=INSTANCE_TYPE,
1652-
entrypoint=["/opt/program/analyze"],
16531651
volume_size_in_gb=VOLUME_SIZE_IN_GB,
16541652
volume_kms_key=volume_kms_key,
16551653
output_kms_key=output_kms_key,
@@ -1880,7 +1878,6 @@ def test_byoc_monitor_suggest_baseline_and_create_monitoring_schedule_without_cu
18801878
image_uri=DefaultModelMonitor._get_default_image_uri(
18811879
sagemaker_session.boto_session.region_name
18821880
),
1883-
entrypoint=["/opt/program/analyze"],
18841881
sagemaker_session=sagemaker_session,
18851882
env=byoc_env,
18861883
)
@@ -2087,7 +2084,6 @@ def test_byoc_monitor_create_and_update_schedule_config_with_customizations(
20872084
),
20882085
instance_count=INSTANCE_COUNT,
20892086
instance_type=INSTANCE_TYPE,
2090-
entrypoint=["/opt/program/analyze"],
20912087
volume_size_in_gb=VOLUME_SIZE_IN_GB,
20922088
volume_kms_key=volume_kms_key,
20932089
output_kms_key=output_kms_key,
@@ -2600,7 +2596,6 @@ def test_byoc_monitor_attach_followed_by_baseline_and_update_monitoring_schedule
26002596
def test_byoc_monitor_monitoring_execution_interactions(
26012597
sagemaker_session, byoc_monitoring_schedule_name
26022598
):
2603-
26042599
my_attached_monitor = ModelMonitor.attach(
26052600
monitor_schedule_name=byoc_monitoring_schedule_name, sagemaker_session=sagemaker_session
26062601
)

0 commit comments

Comments
 (0)