Skip to content

Commit c42aac4

Browse files
tejaschumbalkarmufaddal-rohawala
tejaschumbalkar
and
mufaddal-rohawala
authored
feat: add support for PT1.12.1 (#3468)
Co-authored-by: Mufaddal Rohawala <[email protected]>
1 parent 885423c commit c42aac4

File tree

4 files changed

+76
-2
lines changed

4 files changed

+76
-2
lines changed

‎src/sagemaker/fw_utils.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
"1.11.0",
124124
"1.12",
125125
"1.12.0",
126+
"1.12.1",
126127
],
127128
}
128129

@@ -134,6 +135,7 @@
134135
"1.11.0",
135136
"1.12",
136137
"1.12.0",
138+
"1.12.1",
137139
]
138140

139141

‎src/sagemaker/image_uri_config/pytorch.json‎

Lines changed: 70 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"1.9": "1.9.1",
6969
"1.10": "1.10.2",
7070
"1.11": "1.11.0",
71-
"1.12": "1.12.0"
71+
"1.12": "1.12.1"
7272
},
7373
"versions": {
7474
"0.4.0": {
@@ -651,6 +651,40 @@
651651
"us-west-2": "763104351884"
652652
},
653653
"repository": "pytorch-inference"
654+
},
655+
"1.12.1": {
656+
"py_versions": [
657+
"py38"
658+
],
659+
"registries": {
660+
"af-south-1": "626614931356",
661+
"ap-east-1": "871362719292",
662+
"ap-northeast-1": "763104351884",
663+
"ap-northeast-2": "763104351884",
664+
"ap-northeast-3": "364406365360",
665+
"ap-south-1": "763104351884",
666+
"ap-southeast-1": "763104351884",
667+
"ap-southeast-2": "763104351884",
668+
"ap-southeast-3": "907027046896",
669+
"ca-central-1": "763104351884",
670+
"cn-north-1": "727897471807",
671+
"cn-northwest-1": "727897471807",
672+
"eu-central-1": "763104351884",
673+
"eu-north-1": "763104351884",
674+
"eu-west-1": "763104351884",
675+
"eu-west-2": "763104351884",
676+
"eu-west-3": "763104351884",
677+
"eu-south-1": "692866216735",
678+
"me-south-1": "217643126080",
679+
"sa-east-1": "763104351884",
680+
"us-east-1": "763104351884",
681+
"us-east-2": "763104351884",
682+
"us-gov-west-1": "442386744353",
683+
"us-iso-east-1": "886529160074",
684+
"us-west-1": "763104351884",
685+
"us-west-2": "763104351884"
686+
},
687+
"repository": "pytorch-inference"
654688
}
655689
}
656690
},
@@ -718,7 +752,7 @@
718752
"1.9": "1.9.1",
719753
"1.10": "1.10.2",
720754
"1.11": "1.11.0",
721-
"1.12": "1.12.0"
755+
"1.12": "1.12.1"
722756
},
723757
"versions": {
724758
"0.4.0": {
@@ -1302,6 +1336,40 @@
13021336
"us-west-2": "763104351884"
13031337
},
13041338
"repository": "pytorch-training"
1339+
},
1340+
"1.12.1": {
1341+
"py_versions": [
1342+
"py38"
1343+
],
1344+
"registries": {
1345+
"af-south-1": "626614931356",
1346+
"ap-east-1": "871362719292",
1347+
"ap-northeast-1": "763104351884",
1348+
"ap-northeast-2": "763104351884",
1349+
"ap-northeast-3": "364406365360",
1350+
"ap-south-1": "763104351884",
1351+
"ap-southeast-1": "763104351884",
1352+
"ap-southeast-2": "763104351884",
1353+
"ap-southeast-3": "907027046896",
1354+
"ca-central-1": "763104351884",
1355+
"cn-north-1": "727897471807",
1356+
"cn-northwest-1": "727897471807",
1357+
"eu-central-1": "763104351884",
1358+
"eu-north-1": "763104351884",
1359+
"eu-west-1": "763104351884",
1360+
"eu-west-2": "763104351884",
1361+
"eu-west-3": "763104351884",
1362+
"eu-south-1": "692866216735",
1363+
"me-south-1": "217643126080",
1364+
"sa-east-1": "763104351884",
1365+
"us-east-1": "763104351884",
1366+
"us-east-2": "763104351884",
1367+
"us-gov-west-1": "442386744353",
1368+
"us-iso-east-1": "886529160074",
1369+
"us-west-1": "763104351884",
1370+
"us-west-2": "763104351884"
1371+
},
1372+
"repository": "pytorch-training"
13051373
}
13061374
}
13071375
}

‎tests/scripts/run-notebook-test.sh‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ echo "set SAGEMAKER_ROLE_ARN=$SAGEMAKER_ROLE_ARN"
119119
--region us-west-2 \
120120
--lifecycle-config-name $LIFECYCLE_CONFIG_NAME \
121121
--notebook-instance-role-arn $SAGEMAKER_ROLE_ARN \
122+
--platformIdentifier notebook-al2-v2 \
122123
./amazon-sagemaker-examples/sagemaker_processing/spark_distributed_data_processing/sagemaker-spark-processing.ipynb \
123124
./amazon-sagemaker-examples/advanced_functionality/kmeans_bring_your_own_model/kmeans_bring_your_own_model.ipynb \
124125
./amazon-sagemaker-examples/advanced_functionality/tensorflow_iris_byom/tensorflow_BYOM_iris.ipynb \

‎tests/unit/test_fw_utils.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -864,6 +864,7 @@ def test_validate_smdataparallel_args_not_raises():
864864
("ml.p3.16xlarge", "pytorch", "1.11.0", "py38", smdataparallel_enabled),
865865
("ml.p3.16xlarge", "pytorch", "1.11", "py38", smdataparallel_enabled),
866866
("ml.p3.16xlarge", "pytorch", "1.12.0", "py38", smdataparallel_enabled),
867+
("ml.p3.16xlarge", "pytorch", "1.12.1", "py38", smdataparallel_enabled),
867868
("ml.p3.16xlarge", "pytorch", "1.12", "py38", smdataparallel_enabled),
868869
("ml.p3.16xlarge", "tensorflow", "2.4.1", "py3", smdataparallel_enabled_custom_mpi),
869870
("ml.p3.16xlarge", "tensorflow", "2.4.1", "py37", smdataparallel_enabled_custom_mpi),
@@ -882,6 +883,7 @@ def test_validate_smdataparallel_args_not_raises():
882883
("ml.p3.16xlarge", "pytorch", "1.10.2", "py38", smdataparallel_enabled_custom_mpi),
883884
("ml.p3.16xlarge", "pytorch", "1.11.0", "py38", smdataparallel_enabled_custom_mpi),
884885
("ml.p3.16xlarge", "pytorch", "1.12.0", "py38", smdataparallel_enabled_custom_mpi),
886+
("ml.p3.16xlarge", "pytorch", "1.12.1", "py38", smdataparallel_enabled_custom_mpi),
885887
]
886888
for instance_type, framework_name, framework_version, py_version, distribution in good_args:
887889
fw_utils._validate_smdataparallel_args(
@@ -917,6 +919,7 @@ def test_validate_pytorchddp_not_raises():
917919
"1.11.0",
918920
"1.12",
919921
"1.12.0",
922+
"1.12.1",
920923
]
921924
for framework_version in pytorchddp_supported_fw_versions:
922925
fw_utils.validate_pytorch_distribution(

0 commit comments

Comments
 (0)