Skip to content

Commit de7e204

Browse files
zuoyuanhZuoyuan Huang
andauthored
fix: Neuronx image retrieval missing sdk information (#3948)
Co-authored-by: Zuoyuan Huang <[email protected]>
1 parent 24b41bc commit de7e204

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/sagemaker/image_uris.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,10 @@ def retrieve(
210210
"huggingface-tensorflow-trcomp-training",
211211
]:
212212
_version = version
213-
if repo in ["huggingface-pytorch-inference-neuron"]:
213+
if repo in [
214+
"huggingface-pytorch-inference-neuron",
215+
"huggingface-pytorch-inference-neuronx",
216+
]:
214217
if not sdk_version:
215218
sdk_version = _get_latest_versions(version_config["sdk_versions"])
216219
container_version = sdk_version + "-" + container_version

tests/unit/sagemaker/huggingface/test_estimator.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ def test_huggingface_neuronx(
291291
)
292292
container = huggingface_model.prepare_container_def("ml.inf2.xlarge", inference_tool="neuronx")
293293
assert container["Image"]
294+
assert "sdk" in container["Image"] and "py" in container["Image"]
294295

295296

296297
def test_attach(

0 commit comments

Comments
 (0)