Skip to content

Commit e9fd745

Browse files
authored
fix: skip EFS tests until they are confirmed fixed. (#1007)
* skip EFS tests until they are confirmed fixed.
1 parent 4dc6a5e commit e9fd745

File tree

3 files changed

+36
-0
lines changed

3 files changed

+36
-0
lines changed

tests/integ/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@
7171
NO_LDA_REGIONS = ["eu-west-3", "eu-north-1", "sa-east-1", "ap-east-1"]
7272
NO_MARKET_PLACE_REGIONS = ["eu-west-3", "eu-north-1", "sa-east-1", "ap-east-1"]
7373

74+
EFS_TEST_ENABLED_REGION = ["us-west-2"]
75+
7476
logging.getLogger("boto3").setLevel(logging.INFO)
7577
logging.getLogger("botocore").setLevel(logging.INFO)
7678

tests/integ/test_kmeans_efs_fsx.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
import pytest
1616

17+
import tests.integ
1718
from sagemaker import KMeans
1819
from sagemaker.amazon.amazon_estimator import FileSystemRecordSet
1920
from sagemaker.parameter import IntegerParameter, CategoricalParameter
@@ -44,6 +45,10 @@ def efs_fsx_setup(sagemaker_session):
4445
tear_down(sagemaker_session, fs_resources)
4546

4647

48+
@pytest.mark.skipif(
49+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
50+
reason="EFS integration tests need to be fixed before running in all regions.",
51+
)
4752
def test_kmeans_efs(efs_fsx_setup, sagemaker_session, cpu_instance_type):
4853
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
4954
subnets = [efs_fsx_setup.subnet_id]
@@ -74,6 +79,10 @@ def test_kmeans_efs(efs_fsx_setup, sagemaker_session, cpu_instance_type):
7479
assert_s3_files_exist(sagemaker_session, model_path, ["model.tar.gz"])
7580

7681

82+
@pytest.mark.skipif(
83+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
84+
reason="EFS integration tests need to be fixed before running in all regions.",
85+
)
7786
def test_kmeans_fsx(efs_fsx_setup, sagemaker_session, cpu_instance_type):
7887
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
7988
subnets = [efs_fsx_setup.subnet_id]
@@ -104,6 +113,10 @@ def test_kmeans_fsx(efs_fsx_setup, sagemaker_session, cpu_instance_type):
104113
assert_s3_files_exist(sagemaker_session, model_path, ["model.tar.gz"])
105114

106115

116+
@pytest.mark.skipif(
117+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
118+
reason="EFS integration tests need to be fixed before running in all regions.",
119+
)
107120
def test_tuning_kmeans_efs(efs_fsx_setup, sagemaker_session, cpu_instance_type):
108121
subnets = [efs_fsx_setup.subnet_id]
109122
security_group_ids = efs_fsx_setup.security_group_ids
@@ -160,6 +173,10 @@ def test_tuning_kmeans_efs(efs_fsx_setup, sagemaker_session, cpu_instance_type):
160173
assert best_training_job
161174

162175

176+
@pytest.mark.skipif(
177+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
178+
reason="EFS integration tests need to be fixed before running in all regions.",
179+
)
163180
def test_tuning_kmeans_fsx(efs_fsx_setup, sagemaker_session, cpu_instance_type):
164181
subnets = [efs_fsx_setup.subnet_id]
165182
security_group_ids = efs_fsx_setup.security_group_ids

tests/integ/test_tf_efs_fsx.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import pytest
1919

20+
import tests.integ
2021
from sagemaker.inputs import FileSystemInput
2122
from sagemaker.parameter import IntegerParameter
2223
from sagemaker.tensorflow import TensorFlow
@@ -47,6 +48,10 @@ def efs_fsx_setup(sagemaker_session):
4748
tear_down(sagemaker_session, fs_resources)
4849

4950

51+
@pytest.mark.skipif(
52+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
53+
reason="EFS integration tests need to be fixed before running in all regions.",
54+
)
5055
def test_mnist_efs(efs_fsx_setup, sagemaker_session, cpu_instance_type):
5156
role = efs_fsx_setup.role_name
5257
subnets = [efs_fsx_setup.subnet_id]
@@ -79,6 +84,10 @@ def test_mnist_efs(efs_fsx_setup, sagemaker_session, cpu_instance_type):
7984
)
8085

8186

87+
@pytest.mark.skipif(
88+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
89+
reason="EFS integration tests need to be fixed before running in all regions.",
90+
)
8291
def test_mnist_lustre(efs_fsx_setup, sagemaker_session, cpu_instance_type):
8392
role = efs_fsx_setup.role_name
8493
subnets = [efs_fsx_setup.subnet_id]
@@ -111,6 +120,10 @@ def test_mnist_lustre(efs_fsx_setup, sagemaker_session, cpu_instance_type):
111120
)
112121

113122

123+
@pytest.mark.skipif(
124+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
125+
reason="EFS integration tests need to be fixed before running in all regions.",
126+
)
114127
def test_tuning_tf_script_mode_efs(efs_fsx_setup, sagemaker_session, cpu_instance_type):
115128
role = efs_fsx_setup.role_name
116129
subnets = [efs_fsx_setup.subnet_id]
@@ -155,6 +168,10 @@ def test_tuning_tf_script_mode_efs(efs_fsx_setup, sagemaker_session, cpu_instanc
155168
assert best_training_job
156169

157170

171+
@pytest.mark.skipif(
172+
tests.integ.test_region() not in tests.integ.EFS_TEST_ENABLED_REGION,
173+
reason="EFS integration tests need to be fixed before running in all regions.",
174+
)
158175
def test_tuning_tf_script_mode_lustre(efs_fsx_setup, sagemaker_session, cpu_instance_type):
159176
role = efs_fsx_setup.role_name
160177
subnets = [efs_fsx_setup.subnet_id]

0 commit comments

Comments
 (0)