Skip to content

Commit fa044d5

Browse files
author
Bryannah Hernandez
committed
making .txt evaluate to true
1 parent b22492d commit fa044d5

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

src/sagemaker/serve/builder/requirements_manager.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@
1616
import os
1717
import subprocess
1818

19+
from typing import Optional
20+
1921
logger = logging.getLogger(__name__)
2022

2123

2224
class RequirementsManager:
2325
"""Manages dependency installation by detecting file types"""
2426

25-
def capture_and_install_dependencies(self, dependencies: str = None) -> str:
27+
def capture_and_install_dependencies(self, dependencies: Optional[str] = None) -> str:
2628
"""Detects the type of file dependencies will be installed from
2729
2830
If a req.txt or conda.yml file is provided, it verifies their existence and
@@ -34,15 +36,15 @@ def capture_and_install_dependencies(self, dependencies: str = None) -> str:
3436
Returns:
3537
file path of the existing or generated dependencies file
3638
"""
37-
dependencies = self._detect_conda_env_and_local_dependencies()
39+
_dependencies = dependencies or self._detect_conda_env_and_local_dependencies()
3840

3941
# Dependencies specified as either req.txt or conda_env.yml
40-
if dependencies.endswith(".txt"):
42+
if _dependencies.endswith(".txt"):
4143
self._install_requirements_txt()
42-
elif dependencies.endswith(".yml"):
44+
elif _dependencies.endswith(".yml"):
4345
self._update_conda_env_in_path()
4446
else:
45-
raise ValueError(f'Invalid dependencies provided: "{dependencies}"')
47+
raise ValueError(f'Invalid dependencies provided: "{_dependencies}"')
4648

4749
def _install_requirements_txt(self):
4850
"""Install requirements.txt file using pip"""
@@ -81,7 +83,10 @@ def _detect_conda_env_and_local_dependencies(self) -> str:
8183
conda_env_prefix = self._get_active_conda_env_prefix()
8284

8385
if conda_env_name is None and conda_env_prefix is None:
84-
raise ValueError("No conda environment seems to be active.")
86+
local_dependencies_path = os.path.join(os.getcwd(), "in_process_requirements.txt")
87+
logger.info(local_dependencies_path)
88+
89+
return local_dependencies_path
8590

8691
if conda_env_name == "base":
8792
logger.warning(

0 commit comments

Comments
 (0)