Skip to content

Commit fe9d105

Browse files
committed
fix: Move sagemaker-mlflow to extras
1 parent dc0860d commit fe9d105

File tree

6 files changed

+12
-4
lines changed

6 files changed

+12
-4
lines changed

hatch_build.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def read_feature_deps(feature):
2020

2121
optional_dependencies = {"all": []}
2222

23-
for feature in ("feature-processor", "huggingface", "local", "scipy"):
23+
for feature in ("feature-processor", "huggingface", "local", "scipy", "sagemaker-mlflow"):
2424
dependencies = read_feature_deps(feature)
2525
optional_dependencies[feature] = dependencies
2626
optional_dependencies["all"].extend(dependencies)

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ dependencies = [
4848
"PyYAML~=6.0",
4949
"requests",
5050
"sagemaker-core>=1.0.0,<2.0.0",
51-
"sagemaker-mlflow",
5251
"schema",
5352
"smdebug_rulesconfig==1.0.1",
5453
"tblib>=1.7.0,<4",
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
sagemaker-mlflow>=0.1.0

requirements/extras/test_requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,4 @@ huggingface_hub>=0.23.4
4444
uvicorn>=0.30.1
4545
fastapi>=0.111.0
4646
nest-asyncio
47+
sagemaker-mlflow>=0.1.0

src/sagemaker/estimator.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,10 @@
107107
from sagemaker.workflow.parameters import ParameterString
108108
from sagemaker.workflow.pipeline_context import PipelineSession, runnable_by_pipeline
109109

110-
from sagemaker.mlflow.forward_sagemaker_metrics import log_sagemaker_job_to_mlflow
110+
try:
111+
from sagemaker.mlflow.forward_sagemaker_metrics import log_sagemaker_job_to_mlflow
112+
except ImportError:
113+
raise ValueError("Unable to import mlflow, check if sagemaker-mlflow is installed.")
111114

112115
logger = logging.getLogger(__name__)
113116

src/sagemaker/mlflow/forward_sagemaker_metrics.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@
2020
import re
2121
from typing import Set, Tuple, List, Dict, Generator
2222
import boto3
23-
import mlflow
23+
24+
try:
25+
import mlflow
26+
except ImportError:
27+
raise ValueError("Unable to import mlflow, check if sagemaker-mlflow is installed.")
2428
from mlflow import MlflowClient
2529
from mlflow.entities import Metric, Param, RunTag
2630

0 commit comments

Comments
 (0)