PR 4946 added an unmaintained package omegaconf to sagemaker-python-sdk thats breaking dependency

[sateeshmannar]

Describe the bug
#4946 added "omegaconf>=2.2,<2.3", which was subsequently updated to "omegaconf>=2.2,<=2.3" - This unmaintained package is causing dependency issue with newer version of antlr4-python3-runtime

omegaconf hasnt been updatede in well over 3 years. this package uses antlr4-python3-runtime==4.9.* which has several deprecation warnings.

In addition, an internal package we use dependents on a newer version antlr4-python3-runtime<5.0.0 and >=4.13.0 (to mitigate deprecation warnings and to use the updated functions) and sagemaker in the same Notebook environment.

We are unable to upgrade sagemaker-python-sdk since 2.236.0 when omegaconf was added.

Can this be reviewed and the change that added omegaconf possibly be revert or pick another package that is supported/maintained to accomplish the functions omegaconf provides?

To reproduce
try installing antlr4-python3-runtime and sagemaker package without any specific version in a venv.

Expected behavior
user should be able to upgrade transitive packages and not be stuck at a certain sagemaker version.

Screenshots or logs

The conflict is caused by:
    [custom internal package] 4.7.4 depends on antlr4-python3-runtime<5.0.0 and >=4.13.0
    omegaconf 2.3.0 depends on antlr4-python3-runtime==4.9.*

System information
A description of your system. Please provide:

• SageMaker Python SDK version: >=2.236.0
• Framework name (eg. PyTorch) or algorithm (eg. KMeans): pip install dependency confict
• Framework version:
• Python version: 3.12
• CPU or GPU: CPU
• Custom Docker image (Y/N):NA

Additional context
As part of PR review, can you please ensure a verification step/check is added to verify that any new packages included as part of a PR is maintained and supported in the past 12 months and issues for the included packages are being actively worked on before the PR is approved?

[benieric]

Hello @sateeshmannar , omegaconf is still maintained. From looking at recent GitHub issues it looks like they recently released a dev version that no longer has this dependency - omry/omegaconf#1181

[benieric]

We would need to update dependencies to allow for >=2.2 for the new 2.4 dev version to be usable with the SDK

[sateeshmannar]

Thank you for the update. Can you confirm if you or someone will be pushing a PR to update? Any visibility into the timeline for this update wold be great.

[benieric]

I went ahead and rasied the PR, we usually do releases once a week. Hopefully should be included by next release

[astrojuanlu]

omegaconf is still maintained

"Sort of" omry/omegaconf#1200 (comment)

[pintaoz-aws]

Merged #5168