From b22782042f176719572983faff7b608ccb10156a Mon Sep 17 00:00:00 2001 From: Pravali Uppugunduri Date: Tue, 3 Sep 2024 16:58:25 +0000 Subject: [PATCH 1/3] add deployment config type to response url --- src/sagemaker/serve/builder/jumpstart_builder.py | 4 ++++ src/sagemaker/serve/utils/telemetry_logger.py | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/sagemaker/serve/builder/jumpstart_builder.py b/src/sagemaker/serve/builder/jumpstart_builder.py index eb57dec1fa..ee9ef317a5 100644 --- a/src/sagemaker/serve/builder/jumpstart_builder.py +++ b/src/sagemaker/serve/builder/jumpstart_builder.py @@ -121,6 +121,8 @@ def __init__(self): self.is_compiled = False self.is_quantized = False self.speculative_decoding_draft_model_source = None + self.is_set_deployment_config = False + self.deployment_config_name = None @abstractmethod def _prepare_for_mode(self, **kwargs): @@ -511,6 +513,8 @@ def set_deployment_config(self, config_name: str, instance_type: str) -> None: raise Exception("Cannot set deployment config to an uninitialized model.") self.pysdk_model.set_deployment_config(config_name, instance_type) + is_set_deployment_config = True + self.deployment_config_name = config_name self.instance_type = instance_type diff --git a/src/sagemaker/serve/utils/telemetry_logger.py b/src/sagemaker/serve/utils/telemetry_logger.py index 0ea6ec3f26..a4815d53e5 100644 --- a/src/sagemaker/serve/utils/telemetry_logger.py +++ b/src/sagemaker/serve/utils/telemetry_logger.py @@ -164,6 +164,10 @@ def wrapper(self, *args, **kwargs): ) model_provider_value = SD_DRAFT_MODEL_SOURCE_TO_CODE[str(model_provider_enum)] extra += f"&x-sdDraftModelSource={model_provider_value}" + + if getattr(self, "deployment_config_name", False): + config_name_code = self.deployment_config_name.lower() + extra += f"&x-configName={config_name_code}" extra += f"&x-latency={round(elapsed, 2)}" From 5901a6ae0f9d69b5f4bd70d6e075b4383f356350 Mon Sep 17 00:00:00 2001 From: Pravali Uppugunduri Date: Wed, 4 Sep 2024 18:19:28 +0000 Subject: [PATCH 2/3] Trigger PR checks From 507db15454ba341e3f9b087d477d1ad20b423dee Mon Sep 17 00:00:00 2001 From: Pravali Uppugunduri Date: Wed, 4 Sep 2024 18:19:28 +0000 Subject: [PATCH 3/3] Trigger PR checks --- src/sagemaker/serve/builder/jumpstart_builder.py | 2 -- src/sagemaker/serve/utils/telemetry_logger.py | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/sagemaker/serve/builder/jumpstart_builder.py b/src/sagemaker/serve/builder/jumpstart_builder.py index ee9ef317a5..d2bab2a759 100644 --- a/src/sagemaker/serve/builder/jumpstart_builder.py +++ b/src/sagemaker/serve/builder/jumpstart_builder.py @@ -121,7 +121,6 @@ def __init__(self): self.is_compiled = False self.is_quantized = False self.speculative_decoding_draft_model_source = None - self.is_set_deployment_config = False self.deployment_config_name = None @abstractmethod @@ -513,7 +512,6 @@ def set_deployment_config(self, config_name: str, instance_type: str) -> None: raise Exception("Cannot set deployment config to an uninitialized model.") self.pysdk_model.set_deployment_config(config_name, instance_type) - is_set_deployment_config = True self.deployment_config_name = config_name self.instance_type = instance_type diff --git a/src/sagemaker/serve/utils/telemetry_logger.py b/src/sagemaker/serve/utils/telemetry_logger.py index a4815d53e5..6a1228ba40 100644 --- a/src/sagemaker/serve/utils/telemetry_logger.py +++ b/src/sagemaker/serve/utils/telemetry_logger.py @@ -164,7 +164,7 @@ def wrapper(self, *args, **kwargs): ) model_provider_value = SD_DRAFT_MODEL_SOURCE_TO_CODE[str(model_provider_enum)] extra += f"&x-sdDraftModelSource={model_provider_value}" - + if getattr(self, "deployment_config_name", False): config_name_code = self.deployment_config_name.lower() extra += f"&x-configName={config_name_code}"