From 4d4f91f759faa1cfc2c8f0ac25dec43e72805b8e Mon Sep 17 00:00:00 2001 From: Pravali Uppugunduri Date: Wed, 4 Sep 2024 22:34:47 +0000 Subject: [PATCH 1/4] feat: add deployment config name in modelbuilder telemetry --- src/sagemaker/serve/builder/jumpstart_builder.py | 2 ++ src/sagemaker/serve/utils/telemetry_logger.py | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/src/sagemaker/serve/builder/jumpstart_builder.py b/src/sagemaker/serve/builder/jumpstart_builder.py index e689f41839..cfb43b813a 100644 --- a/src/sagemaker/serve/builder/jumpstart_builder.py +++ b/src/sagemaker/serve/builder/jumpstart_builder.py @@ -121,6 +121,7 @@ def __init__(self): self.is_compiled = False self.is_quantized = False self.speculative_decoding_draft_model_source = None + self.deployment_config_name = None self.name = None @abstractmethod @@ -515,6 +516,7 @@ def set_deployment_config(self, config_name: str, instance_type: str) -> None: raise Exception("Cannot set deployment config to an uninitialized model.") self.pysdk_model.set_deployment_config(config_name, instance_type) + self.deployment_config_name = config_name self.instance_type = instance_type diff --git a/src/sagemaker/serve/utils/telemetry_logger.py b/src/sagemaker/serve/utils/telemetry_logger.py index 0ea6ec3f26..a4815d53e5 100644 --- a/src/sagemaker/serve/utils/telemetry_logger.py +++ b/src/sagemaker/serve/utils/telemetry_logger.py @@ -164,6 +164,10 @@ def wrapper(self, *args, **kwargs): ) model_provider_value = SD_DRAFT_MODEL_SOURCE_TO_CODE[str(model_provider_enum)] extra += f"&x-sdDraftModelSource={model_provider_value}" + + if getattr(self, "deployment_config_name", False): + config_name_code = self.deployment_config_name.lower() + extra += f"&x-configName={config_name_code}" extra += f"&x-latency={round(elapsed, 2)}" From 28a2f241eef10150757a9c5b4413f90413dd577b Mon Sep 17 00:00:00 2001 From: Pravali Uppugunduri Date: Wed, 4 Sep 2024 22:34:47 +0000 Subject: [PATCH 2/4] feat: add deployment config name in modelbuilder telemetry --- src/sagemaker/serve/utils/telemetry_logger.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/sagemaker/serve/utils/telemetry_logger.py b/src/sagemaker/serve/utils/telemetry_logger.py index a4815d53e5..7424cf24c3 100644 --- a/src/sagemaker/serve/utils/telemetry_logger.py +++ b/src/sagemaker/serve/utils/telemetry_logger.py @@ -169,6 +169,10 @@ def wrapper(self, *args, **kwargs): config_name_code = self.deployment_config_name.lower() extra += f"&x-configName={config_name_code}" + if getattr(self, "deployment_config_name", False): + config_name_code = self.deployment_config_name.lower() + extra += f"&x-configName={config_name_code}" + extra += f"&x-latency={round(elapsed, 2)}" if not self.serve_settings.telemetry_opt_out: From 78064bd62b91921813ec7727a5e0fb6d34b7da98 Mon Sep 17 00:00:00 2001 From: Pravali Uppugunduri Date: Thu, 5 Sep 2024 00:18:44 +0000 Subject: [PATCH 3/4] remove duplicate --- src/sagemaker/serve/utils/telemetry_logger.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/sagemaker/serve/utils/telemetry_logger.py b/src/sagemaker/serve/utils/telemetry_logger.py index 7424cf24c3..a4815d53e5 100644 --- a/src/sagemaker/serve/utils/telemetry_logger.py +++ b/src/sagemaker/serve/utils/telemetry_logger.py @@ -169,10 +169,6 @@ def wrapper(self, *args, **kwargs): config_name_code = self.deployment_config_name.lower() extra += f"&x-configName={config_name_code}" - if getattr(self, "deployment_config_name", False): - config_name_code = self.deployment_config_name.lower() - extra += f"&x-configName={config_name_code}" - extra += f"&x-latency={round(elapsed, 2)}" if not self.serve_settings.telemetry_opt_out: From 5d608ec39cf957b5099c09b6735a57b04bcbc52e Mon Sep 17 00:00:00 2001 From: Pravali Uppugunduri Date: Thu, 5 Sep 2024 00:22:24 +0000 Subject: [PATCH 4/4] fix format --- src/sagemaker/serve/utils/telemetry_logger.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sagemaker/serve/utils/telemetry_logger.py b/src/sagemaker/serve/utils/telemetry_logger.py index a4815d53e5..6a1228ba40 100644 --- a/src/sagemaker/serve/utils/telemetry_logger.py +++ b/src/sagemaker/serve/utils/telemetry_logger.py @@ -164,7 +164,7 @@ def wrapper(self, *args, **kwargs): ) model_provider_value = SD_DRAFT_MODEL_SOURCE_TO_CODE[str(model_provider_enum)] extra += f"&x-sdDraftModelSource={model_provider_value}" - + if getattr(self, "deployment_config_name", False): config_name_code = self.deployment_config_name.lower() extra += f"&x-configName={config_name_code}"