From 6a71564d9da327a579a078f54c9170a3e8b21a8f Mon Sep 17 00:00:00 2001 From: txlian Date: Fri, 8 Nov 2024 07:18:44 -0500 Subject: [PATCH 1/2] change: add TGI 2.4.0 image uri --- CONTRIBUTING.md | 38 ++++++++------- .../image_uri_config/huggingface-llm.json | 47 +++++++++++++++++++ .../image_uris/test_huggingface_llm.py | 1 + 3 files changed, 68 insertions(+), 18 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 24226af4ee..ab03be0994 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,23 +9,25 @@ information to effectively respond to your bug report or contribution. ## Table of Contents -* [Report Bugs/Feature Requests](#report-bugsfeature-requests) -* [Contribute via Pull Requests (PRs)](#contribute-via-pull-requests-prs) - * [Set up Your Development Environment *[Optional, but Recommended]*](#set-up-your-development-environment-optional-but-recommended) - * [Pull Down the Code](#pull-down-the-code) - * [Run the Unit Tests](#run-the-unit-tests) - * [Run the Integration Tests](#run-the-integration-tests) - * [Make and Test Your Change](#make-and-test-your-change) - * [Commit Your Change](#commit-your-change) - * [Send a Pull Request](#send-a-pull-request) -* [Documentation Guidelines](#documentation-guidelines) - * [Overviews](#overviews) - * [API References (docstrings)](#api-references-docstrings) - * [Build and Test Documentation](#build-and-test-documentation) -* [Find Contributions to Work On](#find-contributions-to-work-on) -* [Code of Conduct](#code-of-conduct) -* [Security Issue Notifications](#security-issue-notifications) -* [Licensing](#licensing) +- [Contributing Guidelines](#contributing-guidelines) + - [Table of Contents](#table-of-contents) + - [Report Bugs/Feature Requests](#report-bugsfeature-requests) + - [Contribute via Pull Requests (PRs)](#contribute-via-pull-requests-prs) + - [Set up Your Development Environment *\[Optional, but Recommended\]*](#set-up-your-development-environment-optional-but-recommended) + - [Pull Down the Code](#pull-down-the-code) + - [Run the Unit Tests](#run-the-unit-tests) + - [Run the Integration Tests](#run-the-integration-tests) + - [Make and Test Your Change](#make-and-test-your-change) + - [Commit Your Change](#commit-your-change) + - [Send a Pull Request](#send-a-pull-request) + - [Documentation Guidelines](#documentation-guidelines) + - [Overviews](#overviews) + - [API References (docstrings)](#api-references-docstrings) + - [Build and Test Documentation](#build-and-test-documentation) + - [Find Contributions to Work On](#find-contributions-to-work-on) + - [Code of Conduct](#code-of-conduct) + - [Security Issue Notifications](#security-issue-notifications) + - [Licensing](#licensing) ## Report Bugs/Feature Requests @@ -76,7 +78,7 @@ Before sending us a pull request, please ensure that: 1. Install tox using `pip install tox` 1. Install coverage using `pip install .[test]` 1. cd into the sagemaker-python-sdk folder: `cd sagemaker-python-sdk` or `cd /environment/sagemaker-python-sdk` -1. Run the following tox command and verify that all code checks and unit tests pass: `tox tests/unit` +1. Run the following tox command and verify that all code checks and unit tests pass: `tox -- tests/unit` 1. You can also run a single test with the following command: `tox -e py310 -- -s -vv ::` 1. You can run coverage via runcvoerage env : `tox -e runcoverage -- tests/unit` or `tox -e py310 -- tests/unit --cov=sagemaker --cov-append --cov-report xml` * Note that the coverage test will fail if you only run a single test, so make sure to surround the command with `export IGNORE_COVERAGE=-` and `unset IGNORE_COVERAGE` diff --git a/src/sagemaker/image_uri_config/huggingface-llm.json b/src/sagemaker/image_uri_config/huggingface-llm.json index 24cbd5ca96..42f160eff1 100644 --- a/src/sagemaker/image_uri_config/huggingface-llm.json +++ b/src/sagemaker/image_uri_config/huggingface-llm.json @@ -766,6 +766,53 @@ "container_version": { "gpu": "cu124-ubuntu22.04" } + }, + "2.4.0": { + "py_versions": [ + "py311" + ], + "registries": { + "af-south-1": "626614931356", + "il-central-1": "780543022126", + "ap-east-1": "871362719292", + "ap-northeast-1": "763104351884", + "ap-northeast-2": "763104351884", + "ap-northeast-3": "364406365360", + "ap-south-1": "763104351884", + "ap-south-2": "772153158452", + "ap-southeast-1": "763104351884", + "ap-southeast-2": "763104351884", + "ap-southeast-3": "907027046896", + "ap-southeast-4": "457447274322", + "ca-central-1": "763104351884", + "cn-north-1": "727897471807", + "cn-northwest-1": "727897471807", + "eu-central-1": "763104351884", + "eu-central-2": "380420809688", + "eu-north-1": "763104351884", + "eu-west-1": "763104351884", + "eu-west-2": "763104351884", + "eu-west-3": "763104351884", + "eu-south-1": "692866216735", + "eu-south-2": "503227376785", + "me-south-1": "217643126080", + "me-central-1": "914824155844", + "sa-east-1": "763104351884", + "us-east-1": "763104351884", + "us-east-2": "763104351884", + "us-gov-east-1": "446045086412", + "us-gov-west-1": "442386744353", + "us-iso-east-1": "886529160074", + "us-isob-east-1": "094389454867", + "us-west-1": "763104351884", + "us-west-2": "763104351884", + "ca-west-1": "204538143572" + }, + "tag_prefix": "2.4.0-tgi2.4.0", + "repository": "huggingface-pytorch-tgi-inference", + "container_version": { + "gpu": "cu124-ubuntu22.04" + } } } } diff --git a/tests/unit/sagemaker/image_uris/test_huggingface_llm.py b/tests/unit/sagemaker/image_uris/test_huggingface_llm.py index 28525a390c..d993979cfd 100644 --- a/tests/unit/sagemaker/image_uris/test_huggingface_llm.py +++ b/tests/unit/sagemaker/image_uris/test_huggingface_llm.py @@ -46,6 +46,7 @@ "2.0.2": "2.3.0-tgi2.0.2-gpu-py310-cu121-ubuntu22.04", "2.2.0": "2.3.0-tgi2.2.0-gpu-py310-cu121-ubuntu22.04-v2.0", "2.3.1": "2.4.0-tgi2.3.1-gpu-py311-cu124-ubuntu22.04", + "2.4.0": "2.4.0-tgi2.4.0-gpu-py311-cu124-ubuntu22.04", }, "inf2": { "0.0.16": "1.13.1-optimum0.0.16-neuronx-py310-ubuntu22.04", From d73d13ab90bdb945db1a26639bfc3ed90125d69f Mon Sep 17 00:00:00 2001 From: Tony Lian <22435284+tlian25@users.noreply.github.com> Date: Fri, 8 Nov 2024 07:25:03 -0500 Subject: [PATCH 2/2] revert auto-formatting for CONTRIBUTING.md --- CONTRIBUTING.md | 36 +++++++++++++++++------------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ab03be0994..b2bcf44cd1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,25 +9,23 @@ information to effectively respond to your bug report or contribution. ## Table of Contents -- [Contributing Guidelines](#contributing-guidelines) - - [Table of Contents](#table-of-contents) - - [Report Bugs/Feature Requests](#report-bugsfeature-requests) - - [Contribute via Pull Requests (PRs)](#contribute-via-pull-requests-prs) - - [Set up Your Development Environment *\[Optional, but Recommended\]*](#set-up-your-development-environment-optional-but-recommended) - - [Pull Down the Code](#pull-down-the-code) - - [Run the Unit Tests](#run-the-unit-tests) - - [Run the Integration Tests](#run-the-integration-tests) - - [Make and Test Your Change](#make-and-test-your-change) - - [Commit Your Change](#commit-your-change) - - [Send a Pull Request](#send-a-pull-request) - - [Documentation Guidelines](#documentation-guidelines) - - [Overviews](#overviews) - - [API References (docstrings)](#api-references-docstrings) - - [Build and Test Documentation](#build-and-test-documentation) - - [Find Contributions to Work On](#find-contributions-to-work-on) - - [Code of Conduct](#code-of-conduct) - - [Security Issue Notifications](#security-issue-notifications) - - [Licensing](#licensing) +* [Report Bugs/Feature Requests](#report-bugsfeature-requests) +* [Contribute via Pull Requests (PRs)](#contribute-via-pull-requests-prs) + * [Set up Your Development Environment *[Optional, but Recommended]*](#set-up-your-development-environment-optional-but-recommended) + * [Pull Down the Code](#pull-down-the-code) + * [Run the Unit Tests](#run-the-unit-tests) + * [Run the Integration Tests](#run-the-integration-tests) + * [Make and Test Your Change](#make-and-test-your-change) + * [Commit Your Change](#commit-your-change) + * [Send a Pull Request](#send-a-pull-request) +* [Documentation Guidelines](#documentation-guidelines) + * [Overviews](#overviews) + * [API References (docstrings)](#api-references-docstrings) + * [Build and Test Documentation](#build-and-test-documentation) +* [Find Contributions to Work On](#find-contributions-to-work-on) +* [Code of Conduct](#code-of-conduct) +* [Security Issue Notifications](#security-issue-notifications) +* [Licensing](#licensing) ## Report Bugs/Feature Requests