Skip to content

Create GitHub action to trigger canaries #5008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Create GitHub action to trigger canaries #5008

merged 2 commits into from
Feb 4, 2025

Conversation

nileshvd
Copy link
Collaborator

@nileshvd nileshvd commented Jan 28, 2025

Issue #, if available:
N/A

Description of changes:
As part of ORR effort, we need to create canaries that run periodically. We already have GitHub CI Health action that run periodically (every 3 hours) but uses GitHub latest commit and not PySDK distribution from PyPi. So we decided to create similar GitHub action that runs periodically and uses PySDK distribution from PyPi. This effort requires a CodeBuild project and new GitHub action. CodeBuild project is created through different CR

This PR creates GitHub action

Testing done:
Created CodeBuild project in personal AWS account and created a personal GH fork and added this workflow. Ensured that CodeBuild project is successfully triggered after running this workflow

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nileshvd nileshvd requested a review from a team as a code owner January 28, 2025 23:23
@nileshvd nileshvd requested a review from pintaoz-aws January 28, 2025 23:23
@nileshvd nileshvd changed the title [DO NOT MERGE] Create GitHub action to trigger canaries Create GitHub action to trigger canaries Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (a7baead) to head (9b2301c).
Report is 119 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5008      +/-   ##
==========================================
- Coverage   86.57%   86.55%   -0.03%     
==========================================
  Files         440      440              
  Lines       42823    42823              
==========================================
- Hits        37076    37067       -9     
- Misses       5747     5756       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benieric benieric requested review from Erickkbentz and removed request for Erickkbentz February 4, 2025 01:39
@nileshvd nileshvd merged commit d395adc into master Feb 4, 2025
13 of 14 checks passed
@nileshvd nileshvd deleted the canary_action branch February 4, 2025 17:55
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants