Skip to content

fix: bug in get latest version was getting the max sorted alphabetically #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 10, 2025
Merged

fix: bug in get latest version was getting the max sorted alphabetically #5014

merged 16 commits into from
Feb 10, 2025

Conversation

e-davidson
Copy link
Contributor

@e-davidson e-davidson commented Feb 2, 2025 •
edited
Loading

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@e-davidson e-davidson requested a review from a team as a code owner February 2, 2025 17:48
@e-davidson e-davidson changed the title fix: fix fix: bug in get latest version was getting the max sorted alphabetically Feb 3, 2025
evakravi
evakravi reviewed Feb 5, 2025
View reviewed changes
src/sagemaker/jumpstart/utils.py Outdated
@@ -1525,3 +1525,8 @@ def wrapped_f(*args, **kwargs):
if _func is None:
return wrapper_cache
return wrapper_cache(_func)

def get_latest_version(versions: List[str]) -> Optional[str]:
try: return None if not versions else max(versions, key=Version)
Copy link
Member

@evakravi evakravi Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would we return None, does this happen in practice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns none when the list is empty, this was the existing behavior.

evakravi
evakravi previously approved these changes Feb 5, 2025
View reviewed changes
@sage-maker
Copy link
Collaborator

Looks like there's conflicts

@sage-maker
Copy link
Collaborator

Several basic checks like lint and RTD are failing. Please fix.

@sage-maker sage-maker merged commit 133c61d into aws:master Feb 10, 2025
13 of 14 checks passed
evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Mar 20, 2025
@e-davidson @sage-maker @sagemaker-bot
fix: bug in get latest version was getting the max sorted alphabetica…
e4272c2 
…lly (aws#5014)

* fix: bug in get latest version was getting the max sorted alphabetically
instead of sem-ver

* handle invalid sev ver and incompatible sagemaker versions

---------

Co-authored-by: Eli Davidson <[email protected]>
Co-authored-by: parknate@ <[email protected]>
pravali96 pushed a commit to pravali96/sagemaker-python-sdk that referenced this pull request Apr 21, 2025
@e-davidson @sage-maker
fix: bug in get latest version was getting the max sorted alphabetica…
a8e225e 
…lly (aws#5014)

* fix: bug in get latest version was getting the max sorted alphabetically
instead of sem-ver

* handle invalid sev ver and incompatible sagemaker versions

---------

Co-authored-by: Eli Davidson <[email protected]>
Co-authored-by: parknate@ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evakravi evakravi evakravi left review comments

@rsareddy0329 rsareddy0329 Awaiting requested review from rsareddy0329 rsareddy0329 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

+2 more reviewers

@tlian25 tlian25 tlian25 approved these changes

@yusharon yusharon yusharon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@e-davidson @sage-maker @tlian25 @yusharon @evakravi