From f6fbc0ac4da50a70486dcea1a4d4b4eba9d3a594 Mon Sep 17 00:00:00 2001 From: Gokul A Date: Fri, 14 Mar 2025 13:10:28 -0700 Subject: [PATCH 1/5] ADD Documentation to ReadtheDocs for Upgrading torch versions **Description** **Testing Done** Only documentation updates --- doc/overview.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/overview.rst b/doc/overview.rst index 77e6bd0c3b..26601900bd 100644 --- a/doc/overview.rst +++ b/doc/overview.rst @@ -30,6 +30,11 @@ To train a model by using the SageMaker Python SDK, you: After you train a model, you can save it, and then serve the model as an endpoint to get real-time inferences or get inferences for an entire dataset by using batch transform. + +Important Note: + +* When using torch to load Models, it is recommended to use version torch>=2.6.0 and torchvision>=0.17.0 + Prepare a Training script ========================= From fefa1ab187528c787914cbda65615c31bc617fa2 Mon Sep 17 00:00:00 2001 From: Gokul A Date: Fri, 14 Mar 2025 16:17:45 -0700 Subject: [PATCH 2/5] Fix for Codestyle --- .../sagemaker/serve/test_serve_mlflow_pytorch_flavor_happy.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integ/sagemaker/serve/test_serve_mlflow_pytorch_flavor_happy.py b/tests/integ/sagemaker/serve/test_serve_mlflow_pytorch_flavor_happy.py index 38ef1e28a3..345d5e5af9 100644 --- a/tests/integ/sagemaker/serve/test_serve_mlflow_pytorch_flavor_happy.py +++ b/tests/integ/sagemaker/serve/test_serve_mlflow_pytorch_flavor_happy.py @@ -31,7 +31,7 @@ PYTORCH_SQUEEZENET_MLFLOW_RESOURCE_DIR, SERVE_SAGEMAKER_ENDPOINT_TIMEOUT, # SERVE_LOCAL_CONTAINER_TIMEOUT, - PYTHON_VERSION_IS_NOT_310, + # PYTHON_VERSION_IS_NOT_310, ) from tests.integ.timeout import timeout from tests.integ.utils import cleanup_model_resources From d4634ca8ebcb4cab2fa82de64eec1b1a235b4c6b Mon Sep 17 00:00:00 2001 From: Gokul A Date: Fri, 14 Mar 2025 16:28:54 -0700 Subject: [PATCH 3/5] Remove unused import --- tests/integ/sagemaker/experiments/test_run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/integ/sagemaker/experiments/test_run.py b/tests/integ/sagemaker/experiments/test_run.py index 57d3ef41d4..0a3d52b619 100644 --- a/tests/integ/sagemaker/experiments/test_run.py +++ b/tests/integ/sagemaker/experiments/test_run.py @@ -32,7 +32,7 @@ from sagemaker.experiments.trial_component import _TrialComponent from sagemaker.sklearn import SKLearn from sagemaker.utils import retry_with_backoff, unique_name_from_base -from tests.integ.sagemaker.experiments.helpers import name, cleanup_exp_resources, clear_run_context +from tests.integ.sagemaker.experiments.helpers import name, cleanup_exp_resources from sagemaker.experiments.run import ( RUN_NAME_BASE, DELIMITER, From 7ed1bb5b80f98bab2e54b067436b72a5e7e3a4d9 Mon Sep 17 00:00:00 2001 From: Gokul A Date: Fri, 14 Mar 2025 16:32:22 -0700 Subject: [PATCH 4/5] Flake8 Fix --- tests/integ/sagemaker/experiments/test_run.py | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/tests/integ/sagemaker/experiments/test_run.py b/tests/integ/sagemaker/experiments/test_run.py index 0a3d52b619..11fe27a14d 100644 --- a/tests/integ/sagemaker/experiments/test_run.py +++ b/tests/integ/sagemaker/experiments/test_run.py @@ -55,7 +55,7 @@ def artifact_file_path(tempdir): metric_name = "Test-Local-Init-Log-Metric" -def test_local_run_with_load(sagemaker_session, artifact_file_path, clear_run_context): +def test_local_run_with_load(sagemaker_session, artifact_file_path): exp_name = f"My-Local-Exp-{name()}" with cleanup_exp_resources(exp_names=[exp_name], sagemaker_session=sagemaker_session): # Run name is not provided, will create a new TC @@ -87,7 +87,7 @@ def verify_load_run(): def test_two_local_run_init_with_same_run_name_and_different_exp_names( - sagemaker_session, clear_run_context + sagemaker_session ): exp_name1 = f"my-two-local-exp1-{name()}" exp_name2 = f"my-two-local-exp2-{name()}" @@ -127,7 +127,7 @@ def test_two_local_run_init_with_same_run_name_and_different_exp_names( ], ) def test_run_name_vs_trial_component_name_edge_cases( - sagemaker_session, input_names, clear_run_context + sagemaker_session, input_names ): exp_name, run_name, run_display_name = input_names with cleanup_exp_resources(exp_names=[exp_name], sagemaker_session=sagemaker_session): @@ -181,7 +181,6 @@ def test_run_from_local_and_train_job_and_all_exp_cfg_match( execution_role, sagemaker_client_config, sagemaker_metrics_config, - clear_run_context, ): # Notes: # 1. The 1st Run created locally and its exp config was auto passed to the job @@ -282,7 +281,6 @@ def test_run_from_local_and_train_job_and_exp_cfg_not_match( execution_role, sagemaker_client_config, sagemaker_metrics_config, - clear_run_context, ): # Notes: # 1. The 1st Run created locally and its exp config was auto passed to the job @@ -369,7 +367,6 @@ def test_run_from_train_job_only( execution_role, sagemaker_client_config, sagemaker_metrics_config, - clear_run_context, ): # Notes: # 1. No Run created locally or specified in experiment config @@ -420,7 +417,6 @@ def test_run_from_processing_job_and_override_default_exp_config( execution_role, sagemaker_client_config, sagemaker_metrics_config, - clear_run_context, ): # Notes: # 1. The 1st Run (run) created locally @@ -500,7 +496,6 @@ def test_run_from_transform_job( execution_role, sagemaker_client_config, sagemaker_metrics_config, - clear_run_context, ): # Notes: # 1. The 1st Run (run) created locally @@ -582,7 +577,6 @@ def test_load_run_auto_pass_in_exp_config_to_job( execution_role, sagemaker_client_config, sagemaker_metrics_config, - clear_run_context, ): # Notes: # 1. In local side, load the Run created previously and invoke a job under the load context @@ -631,7 +625,7 @@ def test_load_run_auto_pass_in_exp_config_to_job( ) -def test_list(run_obj, sagemaker_session, clear_run_context): +def test_list(run_obj, sagemaker_session): tc1 = _TrialComponent.create( trial_component_name=f"non-run-tc1-{name()}", sagemaker_session=sagemaker_session, @@ -653,7 +647,7 @@ def test_list(run_obj, sagemaker_session, clear_run_context): assert run_tcs[0].experiment_config == run_obj.experiment_config -def test_list_twice(run_obj, sagemaker_session, clear_run_context): +def test_list_twice(run_obj, sagemaker_session): tc1 = _TrialComponent.create( trial_component_name=f"non-run-tc1-{name()}", sagemaker_session=sagemaker_session, From 875a564351d023b445769d225c76322c3cb726bc Mon Sep 17 00:00:00 2001 From: Gokul A Date: Mon, 17 Mar 2025 08:56:40 -0700 Subject: [PATCH 5/5] CodeStyle Fixes --- tests/integ/sagemaker/experiments/test_run.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/integ/sagemaker/experiments/test_run.py b/tests/integ/sagemaker/experiments/test_run.py index 11fe27a14d..4f59d11c54 100644 --- a/tests/integ/sagemaker/experiments/test_run.py +++ b/tests/integ/sagemaker/experiments/test_run.py @@ -86,9 +86,7 @@ def verify_load_run(): retry_with_backoff(verify_load_run, 4) -def test_two_local_run_init_with_same_run_name_and_different_exp_names( - sagemaker_session -): +def test_two_local_run_init_with_same_run_name_and_different_exp_names(sagemaker_session): exp_name1 = f"my-two-local-exp1-{name()}" exp_name2 = f"my-two-local-exp2-{name()}" run_name = "test-run" @@ -126,9 +124,7 @@ def test_two_local_run_init_with_same_run_name_and_different_exp_names( ("my-test4", "test-run", "run-display-name-test"), # with supplied display name ], ) -def test_run_name_vs_trial_component_name_edge_cases( - sagemaker_session, input_names -): +def test_run_name_vs_trial_component_name_edge_cases(sagemaker_session, input_names): exp_name, run_name, run_display_name = input_names with cleanup_exp_resources(exp_names=[exp_name], sagemaker_session=sagemaker_session): with Run(