Skip to content

Conversation

@JunLyu
Copy link
Contributor

@JunLyu JunLyu commented Oct 30, 2025

Issue #, if available:

Description of changes:

  • Previously the code first check if DomainId exists in the resource metadata, then acts accordingly. However, if the ExecutionRoleArn is already in the resource metadata file, the code should just return it.
  • This changes the code to directly return the ExecutionRoleArn if it presents in the resource metadata file

Testing done:
New unit test added

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…n if it presents in the resource metadata file
@JunLyu JunLyu deployed to manual-approval October 30, 2025 01:11 — with GitHub Actions Active
@JunLyu JunLyu marked this pull request as ready for review October 30, 2025 01:34
@JunLyu JunLyu requested a review from a team as a code owner October 30, 2025 01:34
@JunLyu JunLyu requested a review from papriwal October 30, 2025 01:34
@papriwal papriwal merged commit b9df334 into aws:master Oct 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants