Skip to content

Commit 14c867c

Browse files
authored
fix: Make StartingPosition not required in event source schemas (#2813)
1 parent 7191aed commit 14c867c

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

samtranslator/schema/aws_serverless_function.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ class KinesisEventProperties(BaseModel):
164164
MaximumRecordAgeInSeconds: Optional[PassThroughProp] = kinesiseventproperties("MaximumRecordAgeInSeconds")
165165
MaximumRetryAttempts: Optional[PassThroughProp] = kinesiseventproperties("MaximumRetryAttempts")
166166
ParallelizationFactor: Optional[PassThroughProp] = kinesiseventproperties("ParallelizationFactor")
167-
StartingPosition: PassThroughProp = kinesiseventproperties("StartingPosition")
167+
StartingPosition: Optional[PassThroughProp] = kinesiseventproperties("StartingPosition")
168168
StartingPositionTimestamp: Optional[PassThroughProp] = kinesiseventproperties("StartingPositionTimestamp")
169169
Stream: PassThroughProp = kinesiseventproperties("Stream")
170170
TumblingWindowInSeconds: Optional[PassThroughProp] = kinesiseventproperties("TumblingWindowInSeconds")
@@ -188,7 +188,7 @@ class DynamoDBEventProperties(BaseModel):
188188
MaximumRecordAgeInSeconds: Optional[PassThroughProp] = dynamodbeventproperties("MaximumRecordAgeInSeconds")
189189
MaximumRetryAttempts: Optional[PassThroughProp] = dynamodbeventproperties("MaximumRetryAttempts")
190190
ParallelizationFactor: Optional[PassThroughProp] = dynamodbeventproperties("ParallelizationFactor")
191-
StartingPosition: PassThroughProp = dynamodbeventproperties("StartingPosition")
191+
StartingPosition: Optional[PassThroughProp] = dynamodbeventproperties("StartingPosition")
192192
StartingPositionTimestamp: Optional[PassThroughProp] = dynamodbeventproperties("StartingPositionTimestamp")
193193
Stream: PassThroughProp = dynamodbeventproperties("Stream")
194194
TumblingWindowInSeconds: Optional[PassThroughProp] = dynamodbeventproperties("TumblingWindowInSeconds")
@@ -365,7 +365,7 @@ class MSKEventProperties(BaseModel):
365365
ConsumerGroupId: Optional[PassThroughProp] = mskeventproperties("ConsumerGroupId")
366366
FilterCriteria: Optional[PassThroughProp] = mskeventproperties("FilterCriteria")
367367
MaximumBatchingWindowInSeconds: Optional[PassThroughProp] = mskeventproperties("MaximumBatchingWindowInSeconds")
368-
StartingPosition: PassThroughProp = mskeventproperties("StartingPosition")
368+
StartingPosition: Optional[PassThroughProp] = mskeventproperties("StartingPosition")
369369
StartingPositionTimestamp: Optional[PassThroughProp] = mskeventproperties("StartingPositionTimestamp")
370370
Stream: PassThroughProp = mskeventproperties("Stream")
371371
Topics: PassThroughProp = mskeventproperties("Topics")

samtranslator/schema/sam.schema.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,6 @@
721721
}
722722
},
723723
"required": [
724-
"StartingPosition",
725724
"Stream"
726725
],
727726
"title": "DynamoDBEventProperties",
@@ -1449,7 +1448,6 @@
14491448
}
14501449
},
14511450
"required": [
1452-
"StartingPosition",
14531451
"Stream"
14541452
],
14551453
"title": "KinesisEventProperties",
@@ -2039,7 +2037,6 @@
20392037
}
20402038
},
20412039
"required": [
2042-
"StartingPosition",
20432040
"Stream",
20442041
"Topics"
20452042
],

samtranslator/schema/schema.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154159,7 +154159,6 @@
154159154159
}
154160154160
},
154161154161
"required": [
154162-
"StartingPosition",
154163154162
"Stream"
154164154163
],
154165154164
"title": "DynamoDBEventProperties",
@@ -154887,7 +154886,6 @@
154887154886
}
154888154887
},
154889154888
"required": [
154890-
"StartingPosition",
154891154889
"Stream"
154892154890
],
154893154891
"title": "KinesisEventProperties",
@@ -155477,7 +155475,6 @@
155477155475
}
155478155476
},
155479155477
"required": [
155480-
"StartingPosition",
155481155478
"Stream",
155482155479
"Topics"
155483155480
],

0 commit comments

Comments
 (0)