test: disable MSK events in integration tests

MSK tests are created more resources when they start polling (and the Topic we're connecting
from doesn't even exist), so let's create the events with `Enabled: false`, so the polling
doesn't actually start.

Author: valerena

integration/combination/test_function_with_msk.py

@@ -25,12 +25,12 @@ def test_function_with_msk_trigger(self):
         parameters.append(self.generate_parameter("MskClusterName", cluster_name))
         self._common_validations_for_MSK("combination/function_with_msk", parameters)
 
-    def test_function_with_msk_trigger_using_manage_policy(self):
-        companion_stack_outputs = self.companion_stack_outputs
-        parameters = self.get_parameters(companion_stack_outputs)
-        cluster_name = "MskCluster2-" + generate_suffix()
-        parameters.append(self.generate_parameter("MskClusterName2", cluster_name))
-        self._common_validations_for_MSK("combination/function_with_msk_using_managed_policy", parameters)
+    # def test_function_with_msk_trigger_using_manage_policy(self):
+    #     companion_stack_outputs = self.companion_stack_outputs
+    #     parameters = self.get_parameters(companion_stack_outputs)
+    #     cluster_name = "MskCluster2-" + generate_suffix()
+    #     parameters.append(self.generate_parameter("MskClusterName2", cluster_name))
+    #     self._common_validations_for_MSK("combination/function_with_msk_using_managed_policy", parameters)
 
     def test_function_with_msk_trigger_and_s3_onfailure_events_destinations(self):
         companion_stack_outputs = self.companion_stack_outputs
@@ -41,14 +41,14 @@ def test_function_with_msk_trigger_and_s3_onfailure_events_destinations(self):
             "combination/function_with_msk_trigger_and_s3_onfailure_events_destinations", parameters
         )
 
-    def test_function_with_msk_trigger_and_confluent_schema_registry(self):
-        companion_stack_outputs = self.companion_stack_outputs
-        parameters = self.get_parameters(companion_stack_outputs)
-        cluster_name = "MskCluster4-" + generate_suffix()
-        parameters.append(self.generate_parameter("MskClusterName4", cluster_name))
-        self._common_validations_for_MSK(
-            "combination/function_with_msk_trigger_and_confluent_schema_registry", parameters
-        )
+    # def test_function_with_msk_trigger_and_confluent_schema_registry(self):
+    #     companion_stack_outputs = self.companion_stack_outputs
+    #     parameters = self.get_parameters(companion_stack_outputs)
+    #     cluster_name = "MskCluster4-" + generate_suffix()
+    #     parameters.append(self.generate_parameter("MskClusterName4", cluster_name))
+    #     self._common_validations_for_MSK(
+    #         "combination/function_with_msk_trigger_and_confluent_schema_registry", parameters
+    #     )
 
     def _common_validations_for_MSK(self, file_name, parameters):
         self.create_and_verify_stack(file_name, parameters)

integration/resources/templates/combination/function_with_msk.yaml

@@ -60,6 +60,7 @@ Resources:
         MyMskEvent:
           Type: MSK
           Properties:
+            Enabled: false
             StartingPosition: LATEST
             Stream:
               Ref: MyMskCluster

integration/resources/templates/combination/function_with_msk_trigger_and_confluent_schema_registry.yaml

@@ -60,6 +60,7 @@ Resources:
         MyMskEvent:
           Type: MSK
           Properties:
+            Enabled: false
             StartingPosition: LATEST
             Stream:
               Ref: MyMskCluster

integration/resources/templates/combination/function_with_msk_trigger_and_s3_onfailure_events_destinations.yaml

@@ -27,6 +27,12 @@ Resources:
               logs:CreateLogStream, logs:PutLogEvents, s3:ListBucket]
             Effect: Allow
             Resource: '*'
+          - Action: s3:PutObject
+            Effect: Allow
+            Resource:
+              Fn::GetAtt:
+              - PreCreatedS3Bucket
+              - Arn
       ManagedPolicyArns:
       - !Sub arn:${AWS::Partition}:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
       Tags:
@@ -60,6 +66,7 @@ Resources:
         MyMskEvent:
           Type: MSK
           Properties:
+            Enabled: false
             StartingPosition: LATEST
             Stream:
               Ref: MyMskCluster

integration/resources/templates/combination/function_with_msk_using_managed_policy.yaml

@@ -33,6 +33,7 @@ Resources:
         MyMskEvent:
           Type: MSK
           Properties:
+            Enabled: false
             StartingPosition: LATEST
             Stream:
               Ref: MyMskCluster

samtranslator/internal/schema_source/aws_serverless_function.py

@@ -411,6 +411,7 @@ class HttpApiEvent(BaseModel):
 
 class MSKEventProperties(BaseModel):
     ConsumerGroupId: Optional[PassThroughProp] = mskeventproperties("ConsumerGroupId")
+    Enabled: Optional[PassThroughProp]  # TODO: it doesn't show up in docs yet
     FilterCriteria: Optional[PassThroughProp] = mskeventproperties("FilterCriteria")
     KmsKeyArn: Optional[PassThroughProp]  # TODO: add documentation
     MaximumBatchingWindowInSeconds: Optional[PassThroughProp] = mskeventproperties("MaximumBatchingWindowInSeconds")

samtranslator/schema/schema.json

@@ -275792,6 +275792,9 @@
         "DestinationConfig": {
           "$ref": "#/definitions/PassThroughProp"
         },
+        "Enabled": {
+          "$ref": "#/definitions/PassThroughProp"
+        },
         "FilterCriteria": {
           "allOf": [
             {

schema_source/sam.schema.json

@@ -2397,6 +2397,9 @@
         "DestinationConfig": {
           "$ref": "#/definitions/PassThroughProp"
         },
+        "Enabled": {
+          "$ref": "#/definitions/PassThroughProp"
+        },
         "FilterCriteria": {
           "allOf": [
             {