Skip to content

Commit c8ad463

Browse files
authored
chore: remove soft template validation (#2961)
1 parent 738d790 commit c8ad463

File tree

2 files changed

+1
-29
lines changed

2 files changed

+1
-29
lines changed

samtranslator/parser/parser.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from samtranslator.plugins import LifeCycleEvents
1010
from samtranslator.plugins.sam_plugins import SamPlugins
1111
from samtranslator.public.sdk.template import SamTemplate
12-
from samtranslator.validator.validator import SamTemplateValidator
1312
from samtranslator.validator.value_validator import sam_expect
1413

1514
LOG = logging.getLogger(__name__)
@@ -66,12 +65,3 @@ def _validate(self, sam_template, parameter_values): # type: ignore[no-untyped-
6665
raise ValueError("`parameter_values` argument is required")
6766

6867
Parser.validate_datatypes(sam_template) # type: ignore[no-untyped-call]
69-
70-
try:
71-
validator = SamTemplateValidator() # type: ignore[no-untyped-call]
72-
validation_errors = validator.validate(sam_template) # type: ignore[no-untyped-call]
73-
if validation_errors:
74-
LOG.warning("Template schema validation reported the following errors: %s", validation_errors)
75-
except Exception as e:
76-
# Catching any exception and not re-raising to make sure any validation process won't break transform
77-
LOG.exception("Exception from SamTemplateValidator: %s", e)

tests/parser/test_parser.py

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from unittest import TestCase
2-
from unittest.mock import Mock, call, patch
2+
from unittest.mock import Mock, call
33

44
from samtranslator.model.exceptions import InvalidDocumentException
55
from samtranslator.parser.parser import Parser
@@ -19,24 +19,6 @@ def test_parse(self):
1919
parser._validate.assert_has_calls([call(sam_template, parameter_values)])
2020
sam_plugins_mock.act.assert_has_calls([call(LifeCycleEvents.before_transform_template, sam_template)])
2121

22-
@patch("samtranslator.parser.parser.SamTemplateValidator")
23-
@patch("samtranslator.parser.parser.LOG")
24-
def test_validate_validator_failure(self, log_mock, sam_template_validator_class_mock):
25-
exception = Exception()
26-
sam_template_validator_class_mock.side_effect = exception
27-
log_mock.exception = Mock()
28-
29-
sam_template = {
30-
"Resources": {
31-
"Function": {},
32-
"Api": {},
33-
}
34-
}
35-
paramerter_values = {"Param": "value"}
36-
parser = Parser()
37-
parser._validate(sam_template, paramerter_values)
38-
log_mock.exception.assert_has_calls([call("Exception from SamTemplateValidator: %s", exception)])
39-
4022
def test_validate_parameter_values_is_required(self):
4123
parser = Parser()
4224
with self.assertRaises(ValueError):

0 commit comments

Comments
 (0)