feat: Add StartingPositionTimestamp to SelfManagedKafka

GavinZZ · GavinZZ · commit cfdaebba2082 · 2023-06-22T18:12:05.000Z
diff --git a/samtranslator/internal/schema_source/aws_serverless_function.py b/samtranslator/internal/schema_source/aws_serverless_function.py
@@ -441,6 +441,8 @@ class SelfManagedKafkaEventProperties(BaseModel):
         "KafkaBootstrapServers"
     )
     SourceAccessConfigurations: PassThroughProp = selfmanagedkafkaeventproperties("SourceAccessConfigurations")
+    StartingPosition: Optional[PassThroughProp]  # TODO: add documentation
+    StartingPositionTimestamp: Optional[PassThroughProp]  # TODO: add documentation
     Topics: PassThroughProp = selfmanagedkafkaeventproperties("Topics")
 
 
diff --git a/samtranslator/schema/schema.json b/samtranslator/schema/schema.json
@@ -238958,6 +238958,12 @@
           "markdownDescription": "An array of the authentication protocol, VPC components, or virtual host to secure and define your event source\\.  \n*Valid values*: `BASIC_AUTH | CLIENT_CERTIFICATE_TLS_AUTH | SASL_SCRAM_256_AUTH | SASL_SCRAM_512_AUTH | SERVER_ROOT_CA_CERTIFICATE`  \n*Type*: List of [SourceAccessConfiguration](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-eventsourcemapping-sourceaccessconfiguration.html)  \n*Required*: Yes  \n*AWS CloudFormation compatibility*: This property is passed directly to the `[ SourceAccessConfigurations](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html#cfn-lambda-eventsourcemapping-sourceaccessconfigurations)` property of an `AWS::Lambda::EventSourceMapping` resource\\.",
           "title": "SourceAccessConfigurations"
         },
+        "StartingPosition": {
+          "$ref": "#/definitions/PassThroughProp"
+        },
+        "StartingPositionTimestamp": {
+          "$ref": "#/definitions/PassThroughProp"
+        },
         "Topics": {
           "allOf": [
             {
diff --git a/schema_source/sam.schema.json b/schema_source/sam.schema.json
@@ -2753,6 +2753,12 @@
           "markdownDescription": "An array of the authentication protocol, VPC components, or virtual host to secure and define your event source\\.  \n*Valid values*: `BASIC_AUTH | CLIENT_CERTIFICATE_TLS_AUTH | SASL_SCRAM_256_AUTH | SASL_SCRAM_512_AUTH | SERVER_ROOT_CA_CERTIFICATE`  \n*Type*: List of [SourceAccessConfiguration](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-eventsourcemapping-sourceaccessconfiguration.html)  \n*Required*: Yes  \n*AWS CloudFormation compatibility*: This property is passed directly to the `[ SourceAccessConfigurations](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html#cfn-lambda-eventsourcemapping-sourceaccessconfigurations)` property of an `AWS::Lambda::EventSourceMapping` resource\\.",
           "title": "SourceAccessConfigurations"
         },
+        "StartingPosition": {
+          "$ref": "#/definitions/PassThroughProp"
+        },
+        "StartingPositionTimestamp": {
+          "$ref": "#/definitions/PassThroughProp"
+        },
         "Topics": {
           "allOf": [
             {
diff --git a/tests/translator/input/function_with_self_managed_kafka.yaml b/tests/translator/input/function_with_self_managed_kafka.yaml
@@ -24,3 +24,5 @@ Resources:
             - Type: VPC_SECURITY_GROUP
               URI: security_group:sg-67890
             ConsumerGroupId: consumergroup1
+            StartingPosition: AT_TIMESTAMP
+            StartingPositionTimestamp: 1672560000
diff --git a/tests/translator/output/aws-cn/function_with_self_managed_kafka.json b/tests/translator/output/aws-cn/function_with_self_managed_kafka.json
@@ -55,6 +55,8 @@
             "URI": "security_group:sg-67890"
           }
         ],
+        "StartingPosition": "AT_TIMESTAMP",
+        "StartingPositionTimestamp": 1672560000,
         "Topics": [
           "Topic1"
         ]
diff --git a/tests/translator/output/aws-us-gov/function_with_self_managed_kafka.json b/tests/translator/output/aws-us-gov/function_with_self_managed_kafka.json
@@ -55,6 +55,8 @@
             "URI": "security_group:sg-67890"
           }
         ],
+        "StartingPosition": "AT_TIMESTAMP",
+        "StartingPositionTimestamp": 1672560000,
         "Topics": [
           "Topic1"
         ]
diff --git a/tests/translator/output/function_with_self_managed_kafka.json b/tests/translator/output/function_with_self_managed_kafka.json
@@ -55,6 +55,8 @@
             "URI": "security_group:sg-67890"
           }
         ],
+        "StartingPosition": "AT_TIMESTAMP",
+        "StartingPositionTimestamp": 1672560000,
         "Topics": [
           "Topic1"
         ]

Original file line number	Diff line number	Diff line change
`@@ -441,6 +441,8 @@ class SelfManagedKafkaEventProperties(BaseModel):`
`441`	`441`	`"KafkaBootstrapServers"`
`442`	`442`	`)`
`443`	`443`	`SourceAccessConfigurations: PassThroughProp = selfmanagedkafkaeventproperties("SourceAccessConfigurations")`
	`444`	`+ StartingPosition: Optional[PassThroughProp] # TODO: add documentation`
	`445`	`+ StartingPositionTimestamp: Optional[PassThroughProp] # TODO: add documentation`
`444`	`446`	`Topics: PassThroughProp = selfmanagedkafkaeventproperties("Topics")`
`445`	`447`
`446`	`448`
Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,8 @@`
`55`	`55`	`"URI": "security_group:sg-67890"`
`56`	`56`	`}`
`57`	`57`	`],`
	`58`	`+ "StartingPosition": "AT_TIMESTAMP",`
	`59`	`+ "StartingPositionTimestamp": 1672560000,`
`58`	`60`	`"Topics": [`
`59`	`61`	`"Topic1"`
`60`	`62`	`]`