fix: Throw appropriate error message when providing non map route settings (#3507)

Author: GavinZZ

samtranslator/plugins/api/implicit_http_api_plugin.py

@@ -124,6 +124,7 @@ def _add_route_settings_to_api(
 
         # Handle Resource-level conditions if necessary
         api_route_settings = resource.properties.get("RouteSettings", {})
+        sam_expect(api_route_settings, api_id, "RouteSettings").to_be_a_map()
         event_route_settings = event_properties.get("RouteSettings", {})
         if condition:
             event_route_settings = make_conditional(condition, event_properties.get("RouteSettings", {}))

tests/translator/input/error_http_api_list_route_settings.yaml

@@ -0,0 +1,9 @@
+Resources:
+  ChatApi:
+    Type: AWS::Serverless::HttpApi
+    Properties:
+      Name: !Ref 'ChatApiName'
+      RouteSettings:
+      - RouteKey: !Sub 'ANY /${ChatApiName}'
+        ThrottlingBurstLimit: 100
+        ThrottlingRateLimit: 100

tests/translator/output/error_http_api_list_route_settings.json

@@ -0,0 +1,14 @@
+{
+  "_autoGeneratedBreakdownErrorMessage": [
+    "Invalid Serverless Application Specification document. ",
+    "Number of errors found: 1. ",
+    "Resource with id [ChatApi] is invalid. ",
+    "Property 'RouteSettings' should be a map."
+  ],
+  "errorMessage": "Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [ChatApi] is invalid. Property 'RouteSettings' should be a map.",
+  "errors": [
+    {
+      "errorMessage": "Resource with id [ChatApi] is invalid. Property 'RouteSettings' should be a map."
+    }
+  ]
+}